All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Heiko Thiery <heiko.thiery@gmail.com>
Cc: buildroot@buildroot.org, "Jan Kundrát" <jan.kundrat@cesnet.cz>,
	"Fiona Klute" <fiona.klute@gmx.de>
Subject: Re: [Buildroot] [PATCH v2 4/6] package/netopeer2: bump to version 2.2.31
Date: Mon, 30 Dec 2024 12:00:03 +0100	[thread overview]
Message-ID: <20241230120003.68630295@windsurf> (raw)
In-Reply-To: <20241230103534.671602-5-heiko.thiery@gmail.com>

Hello Heiko,

(Thanks for the v2 with all those improvements!)

On Mon, 30 Dec 2024 11:35:36 +0100
Heiko Thiery <heiko.thiery@gmail.com> wrote:


> diff --git a/package/netopeer2/Config.in b/package/netopeer2/Config.in
> index db31a786a1..5adff14ac7 100644
> --- a/package/netopeer2/Config.in
> +++ b/package/netopeer2/Config.in
> @@ -14,9 +14,10 @@ config BR2_PACKAGE_NETOPEER2
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # sysrepo
>  	select BR2_PACKAGE_LIBNETCONF2
>  	select BR2_PACKAGE_LIBSSH
> -	select BR2_PACKAGE_LIBSSH_SERVER # For libnetconf2 to have SSH
> +	select BR2_PACKAGE_LIBSSH_SERVER # For libnetconf2 to have SSH/TLS support
> +	select BR2_PACKAGE_LIBCURL # For libnetconf2 to have SSH/TLS support
> +	select BR2_PACKAGE_OPENSSL # For libnetconf2 to have SSH/TLS support

This is not needed, and the comment is not true: libnetconf2 now
requires openssl unconditionally, so this select is not needed.

>  	select BR2_PACKAGE_LIBYANG
> -	select BR2_PACKAGE_OPENSSL # For libnetconf2 to have TLS
>  	select BR2_PACKAGE_SYSREPO
>  	help
>  	  Netopeer2 is a set of tools implementing network configuration
> @@ -33,4 +34,19 @@ config BR2_PACKAGE_NETOPEER2_CLI
>  	help
>  	  Enable netopeer2 CLI.
>  
> +config BR2_PACKAGE_NETOPEER2_SSH_AUTHORIZED_KEYS_FORMAT
> +	string "ssh authorized keys format"
> +	help
> +	  Enable netopeer2 CLI.

Hu, how is this option related to enabling the CLI ?


> +ifneq ($(call qstrip,$(BR2_PACKAGE_NETOPEER2_SSH_AUTHORIZED_KEYS_FORMAT)),)
> +NETOPEER2_CONF_OPTS += \
> +	-DSSH_AUTHORIZED_KEYS_FORMAT=$(call qstrip,$(BR2_PACKAGE_NETOPEER2_SSH_AUTHORIZED_KEYS_FORMAT))
> +endif

Perhaps:

NETOPEER2_SSH_AUTHORIZED_KEYS_FORMAT = $(call qstrip,$(BR2_PACKAGE_NETOPEER2_SSH_AUTHORIZED_KEYS_FORMAT))
ifneq ($(NETOPEER2_SSH_AUTHORIZED_KEYS_FORMAT),)
NETOPEER2_CONF_OPTS += \
	-DSSH_AUTHORIZED_KEYS_FORMAT="$(NETOPEER2_SSH_AUTHORIZED_KEYS_FORMAT)"
endif

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-12-30 11:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-30 10:35 [Buildroot] [PATCH v2 0/6] netopeer2 package update Heiko Thiery
2024-12-30 10:35 ` [Buildroot] [PATCH v2 1/6] package/libyang: bump to version 3.4.2 Heiko Thiery
2024-12-30 10:35 ` [Buildroot] [PATCH v2 2/6] package/libnetconf2: bump to version 3.5.1 Heiko Thiery
2024-12-30 10:35 ` [Buildroot] [PATCH v2 3/6] package/sysrepo: bump to version 2.11.7 Heiko Thiery
2024-12-30 10:35 ` [Buildroot] [PATCH v2 4/6] package/netopeer2: bump to version 2.2.31 Heiko Thiery
2024-12-30 11:00   ` Thomas Petazzoni via buildroot [this message]
2024-12-30 10:35 ` [Buildroot] [PATCH v2 5/6] support/testing/tests/package/test_sysrepo.py: add new test Heiko Thiery
2024-12-30 10:35 ` [Buildroot] [PATCH v2 6/6] support/testing/tests/package/test_netopeer2.py: " Heiko Thiery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241230120003.68630295@windsurf \
    --to=buildroot@buildroot.org \
    --cc=fiona.klute@gmx.de \
    --cc=heiko.thiery@gmail.com \
    --cc=jan.kundrat@cesnet.cz \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.