From: kernel test robot <lkp@intel.com>
To: cros-kernel-buildreports@googlegroups.com
Cc: oe-kbuild-all@lists.linux.dev
Subject: [chrome-os:chromeos-6.6 99/99] drivers/mailbox/mailbox.c:382:32: error: returning 'void *' from a function with return type 'int' makes integer from pointer without a cast
Date: Mon, 30 Dec 2024 20:10:50 +0800 [thread overview]
Message-ID: <202412302047.5eMBd6G9-lkp@intel.com> (raw)
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-6.6
head: f5002a03972c582b24af87ac1e3c5ffecb07573f
commit: 71e4fcb288df366078213ba4fcf976f12a14d5e2 [99/99] FROMLIST: mailbox: Add power_get/power_put API to mbox_chan_ops
config: arm-randconfig-004-20241230 (https://download.01.org/0day-ci/archive/20241230/202412302047.5eMBd6G9-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241230/202412302047.5eMBd6G9-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412302047.5eMBd6G9-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/mailbox/mailbox.c: In function '__mbox_bind_client':
>> drivers/mailbox/mailbox.c:382:32: error: returning 'void *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion]
382 | return ERR_PTR(ret);
| ^~~~~~~~~~~~
vim +382 drivers/mailbox/mailbox.c
355
356 static int __mbox_bind_client(struct mbox_chan *chan, struct mbox_client *cl)
357 {
358 struct device *dev = cl->dev;
359 unsigned long flags;
360 int ret;
361
362 if (chan->cl || !try_module_get(chan->mbox->dev->driver->owner)) {
363 dev_dbg(dev, "%s: mailbox not free\n", __func__);
364 return -EBUSY;
365 }
366
367 spin_lock_irqsave(&chan->lock, flags);
368 chan->msg_free = 0;
369 chan->msg_count = 0;
370 chan->active_req = NULL;
371 chan->cl = cl;
372 init_completion(&chan->tx_complete);
373
374 if (chan->txdone_method == TXDONE_BY_POLL && cl->knows_txdone)
375 chan->txdone_method = TXDONE_BY_ACK;
376
377 spin_unlock_irqrestore(&chan->lock, flags);
378
379 if (chan->mbox->ops->power_get) {
380 ret = chan->mbox->ops->power_get(chan);
381 if (ret < 0)
> 382 return ERR_PTR(ret);
383 }
384
385 if (chan->mbox->ops->startup) {
386 ret = chan->mbox->ops->startup(chan);
387
388 if (ret) {
389 dev_err(dev, "Unable to startup the chan (%d)\n", ret);
390 mbox_free_channel(chan);
391 return ret;
392 }
393 }
394
395 return 0;
396 }
397
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-12-30 12:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202412302047.5eMBd6G9-lkp@intel.com \
--to=lkp@intel.com \
--cc=cros-kernel-buildreports@googlegroups.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.