Re: [Buildroot] [PATCH v3 3/6] package/sysrepo: bump to version 2.11.7

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello Heiko,

Minor comment below, but since a v4 is anyway needed.

On Mon, 30 Dec 2024 12:37:11 +0100
Heiko Thiery <heiko.thiery@gmail.com> wrote:

> Add new config options to enable/disable binary tools/daemon. By default
> this options are enabled.
> 
> Also some sysv init script shellcheck warnings are fixed.

A pedantic person would have said those shellcheck warning fixes should
have been made in a separate patch. Also if you fix shellcheck
warnings, isn't an update of .checkpackageignore needed, i.e remove:

package/sysrepo/S51sysrepo-plugind Shellcheck lib_sysv.Indent

 ?

> diff --git a/package/sysrepo/Config.in b/package/sysrepo/Config.in
> index b1535bed9f..ff75575952 100644
> --- a/package/sysrepo/Config.in
> +++ b/package/sysrepo/Config.in
> @@ -16,6 +16,27 @@ config BR2_PACKAGE_SYSREPO
>  
>  if BR2_PACKAGE_SYSREPO
>  
> +config BR2_PACKAGE_SYSREPO_SYSREPOCFG
> +	bool "enable sysrepocfg"
> +	default y
> +	help
> +	  Enable sysrepocfg.
> +	  Build binary tool sysrepocfg

These two lines of help text are quite redundant with each other... and
with the prompt of the option.

> +config BR2_PACKAGE_SYSREPO_SYSREPOCTL
> +	bool "enable sysrepoctl"
> +	default y
> +	help
> +	  Enable sysrepoctl.
> +	  Build binary tool sysrepoctl

Same.

> +config BR2_PACKAGE_SYSREPO_PLUGIND
> +	bool "enable sysrepo-plugind"
> +	default y
> +	help
> +	  Enable sysrepo-plugind.
> +	  Build binary daemon sysrepo-plugind

Same.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot