From: Akhil P Oommen <quic_akhilpo@quicinc.com>
To: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
"Konrad Dybcio" <konradybcio@kernel.org>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Akhil P Oommen <quic_akhilpo@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: [PATCH v3 2/6] drm/msm: a6x: Rework qmp_get() error handling
Date: Tue, 31 Dec 2024 02:41:03 +0530 [thread overview]
Message-ID: <20241231-gpu-acd-v3-2-3ba73660e9ca@quicinc.com> (raw)
In-Reply-To: <20241231-gpu-acd-v3-0-3ba73660e9ca@quicinc.com>
Fix the following for qmp_get() errors:
1. Correctly handle probe defer for A6x GPUs
2. Ignore other errors because those are okay when GPU ACD is
not required. They are checked again during gpu acd probe.
Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
---
drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
index 2689e79aefa5..1f213a0fc61b 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
@@ -1844,9 +1844,10 @@ int a6xx_gmu_init(struct a6xx_gpu *a6xx_gpu, struct device_node *node)
goto detach_cxpd;
}
+ /* Other errors are handled during GPU ACD probe */
gmu->qmp = qmp_get(gmu->dev);
- if (IS_ERR(gmu->qmp) && adreno_is_a7xx(adreno_gpu)) {
- ret = PTR_ERR(gmu->qmp);
+ if (PTR_ERR_OR_ZERO(gmu->qmp) == -EPROBE_DEFER) {
+ ret = -EPROBE_DEFER;
goto detach_gxpd;
}
--
2.45.2
next prev parent reply other threads:[~2024-12-30 21:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-30 21:11 [PATCH v3 0/6] Support for GPU ACD feature on Adreno X1-85 Akhil P Oommen
2024-12-30 21:11 ` [PATCH v3 1/6] drm/msm/adreno: Add support for ACD Akhil P Oommen
2024-12-31 9:48 ` neil.armstrong
2025-01-02 10:33 ` Akhil P Oommen
2024-12-30 21:11 ` Akhil P Oommen [this message]
2025-01-03 12:39 ` [PATCH v3 2/6] drm/msm: a6x: Rework qmp_get() error handling Konrad Dybcio
2024-12-30 21:11 ` [PATCH v3 3/6] drm/msm/adreno: Add module param to disable ACD Akhil P Oommen
2024-12-31 10:32 ` Konrad Dybcio
2025-01-06 20:06 ` Akhil P Oommen
2024-12-30 21:11 ` [PATCH v3 4/6] dt-bindings: opp: Add v2-qcom-adreno vendor bindings Akhil P Oommen
2024-12-30 22:25 ` Rob Herring (Arm)
2024-12-31 9:39 ` Konrad Dybcio
2025-01-02 10:28 ` Akhil P Oommen
2024-12-30 21:11 ` [PATCH v3 5/6] arm64: dts: qcom: x1e80100: Add ACD levels for GPU Akhil P Oommen
2024-12-30 21:11 ` [PATCH v3 6/6] arm64: dts: qcom: x1e80100: Add OPPs up to Turbo L3 " Akhil P Oommen
2025-01-03 12:42 ` Konrad Dybcio
2025-01-05 17:55 ` [PATCH v3 0/6] Support for GPU ACD feature on Adreno X1-85 Maya Matuszczyk
2025-01-06 0:55 ` Rob Clark
2025-01-06 19:55 ` Akhil P Oommen
2025-01-08 17:14 ` Maya Matuszczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241231-gpu-acd-v3-2-3ba73660e9ca@quicinc.com \
--to=quic_akhilpo@quicinc.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=nm@ti.com \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.