From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] drm: crtc-helper: Remove useless loop
Date: Wed, 28 May 2014 16:35:50 +0200
Message-ID: <2024324.A0AEyACNkt@avalon>
References: <1401281016-4874-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
 <20140528133638.GV14841@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from perceval.ideasonboard.com (perceval.ideasonboard.com
 [95.142.166.194])
 by gabe.freedesktop.org (Postfix) with ESMTP id DBB7D6E5AC
 for <dri-devel@lists.freedesktop.org>; Wed, 28 May 2014 07:35:30 -0700 (PDT)
In-Reply-To: <20140528133638.GV14841@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, dri-devel@lists.freedesktop.org, Dave Airlie <airlied@redhat.com>
List-Id: dri-devel@lists.freedesktop.org

Hi Daniel,

On Wednesday 28 May 2014 15:36:38 Daniel Vetter wrote:
> On Wed, May 28, 2014 at 02:43:36PM +0200, Laurent Pinchart wrote:
> > Commit e3d6ddb35f6221859b6054879d186e13a3af351e ("drm/crtc-helper: don't
> > disable disconnected outputs") made the for each loop over connectors
> > empty in __drm_helper_disable_unused_functions(). Remove the loop
> > altogether.
> > 
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> 
> Isn't the local variable connector now unused?

Yes it is. Missing hunk in my patch, sorry about that :-/

> At least that's what my old patch did:
> 
> http://patchwork.freedesktop.org/patch/24184/

Looks like I've missed it. Sorry for the noise.

> /me looks at Dave ...
> 
> Cheers, Daniel

-- 
Regards,

Laurent Pinchart