From: Thomas Monjalon <thomas@monjalon.net>
To: Wei Zhao <wei.zhao1@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v7 2/3] net/i40e: implement device reset on port
Date: Thu, 20 Apr 2017 23:20:13 +0200 [thread overview]
Message-ID: <2024625.2sU8lOsUIU@xps> (raw)
In-Reply-To: <1491793349-46840-3-git-send-email-wei.zhao1@intel.com>
10/04/2017 05:02, Wei Zhao:
> + memset(dev->data->dev_private, 0,
> + (uint64_t)&adapter->reset_flag - (uint64_t)adapter);
It does not compile for 32-bit.
Should it be replaced by offsetof()?
Does it mean that new fields should be added before reset_flag?
There is no comment about position importance of this field in the struct.
By the way, there is a field ptype_tbl appeared recently. Where should it
be positionned after rebase?
next prev parent reply other threads:[~2017-04-20 21:20 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 9:34 [PATCH v4 0/3] net/i40e: vf port reset Wei Zhao
2017-03-30 9:34 ` [PATCH v4 1/3] lib/librte_ether: add support for " Wei Zhao
2017-03-30 19:55 ` Thomas Monjalon
2017-04-06 2:57 ` Zhao1, Wei
2017-04-06 7:11 ` Thomas Monjalon
2017-04-06 8:53 ` Zhao1, Wei
2017-04-06 9:02 ` Ananyev, Konstantin
2017-04-10 20:58 ` Thomas Monjalon
2017-04-13 8:55 ` Zhao1, Wei
2017-04-13 10:06 ` Thomas Monjalon
2017-04-14 1:29 ` Zhao1, Wei
2017-04-14 6:31 ` Thomas Monjalon
2017-04-14 8:03 ` Zhao1, Wei
2017-04-17 2:08 ` Zhao1, Wei
2017-04-17 5:02 ` Zhao1, Wei
2017-04-20 6:07 ` Yuanhan Liu
2017-04-20 9:17 ` Zhao1, Wei
2017-04-21 2:27 ` Yuanhan Liu
2017-04-21 8:27 ` Thomas Monjalon
2017-04-21 8:59 ` Zhao1, Wei
2017-04-21 9:28 ` Thomas Monjalon
2017-04-24 2:01 ` Yuanhan Liu
2017-04-24 3:15 ` Zhao1, Wei
2017-04-24 3:39 ` Zhao1, Wei
2017-04-24 8:04 ` Thomas Monjalon
2017-04-25 3:14 ` Zhao1, Wei
2017-04-21 8:55 ` Zhao1, Wei
2017-03-30 9:34 ` [PATCH v4 2/3] net/i40e: implement device reset on port Wei Zhao
2017-03-30 9:34 ` [PATCH v4 3/3] app/testpmd: add port reset command into testpmd Wei Zhao
2017-03-30 12:32 ` [PATCH v4 0/3] net/i40e: vf port reset Wu, Jingjing
2017-04-05 5:42 ` Zhao1, Wei
2017-04-06 6:33 ` [PATCH v5 " Wei Zhao
2017-04-06 6:33 ` [PATCH v5 1/3] lib/librte_ether: add support for " Wei Zhao
2017-04-06 6:33 ` [PATCH v5 2/3] net/i40e: implement device reset on port Wei Zhao
2017-04-06 6:33 ` [PATCH v5 3/3] app/testpmd: add port reset command into testpmd Wei Zhao
2017-04-06 6:51 ` [PATCH v6 0/3] net/i40e: vf port reset Wei Zhao
2017-04-06 6:51 ` [PATCH v6 1/3] lib/librte_ether: add support for " Wei Zhao
2017-04-07 6:58 ` Yang, Qiming
2017-04-10 2:21 ` Zhao1, Wei
2017-04-06 6:51 ` [PATCH v6 2/3] net/i40e: implement device reset on port Wei Zhao
2017-04-06 6:51 ` [PATCH v6 3/3] app/testpmd: add port reset command into testpmd Wei Zhao
2017-04-10 3:02 ` [PATCH v7 0/3] net/i40e: vf port reset Wei Zhao
2017-04-10 3:02 ` [PATCH v7 1/3] lib/librte_ether: add support for " Wei Zhao
2017-04-20 20:49 ` Thomas Monjalon
2017-04-21 3:20 ` Zhao1, Wei
2017-04-20 20:52 ` Thomas Monjalon
2017-04-10 3:02 ` [PATCH v7 2/3] net/i40e: implement device reset on port Wei Zhao
2017-04-20 21:12 ` Thomas Monjalon
2017-04-21 3:39 ` Zhao1, Wei
2017-04-20 21:20 ` Thomas Monjalon [this message]
2017-04-10 3:02 ` [PATCH v7 3/3] app/testpmd: add port reset command into testpmd Wei Zhao
2017-04-20 21:37 ` [PATCH v7 0/3] net/i40e: vf port reset Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024625.2sU8lOsUIU@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=wei.zhao1@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.