From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Thu, 16 Mar 2017 10:11:53 -0400 (EDT) Subject: [Cluster-devel] [PATCH] gfs2: Don't pack struct lm_lockname In-Reply-To: <1489603738-27603-1-git-send-email-agruenba@redhat.com> References: <1489603738-27603-1-git-send-email-agruenba@redhat.com> Message-ID: <2024769933.2970459.1489673513304.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- Original Message ----- | As per a suggestion by Linus, don't pack struct lm_lockname: we did that | because the struct used as a rhashtable key, but packing tells the | compiler that the 64-bit fields in the struct may be unaligned, causing | it to generate worse code on some architectures. Instead, rearrange the | fields in the struct so that there is no padding between fields, and | exclude any tail padding from the hash key size. | | Signed-off-by: Andreas Gruenbacher | --- Hi, Thanks. This is now applied to the for-next branch of the linux-gfs2 tree: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/?h=for-next&id=972b044eeca582ef173d063773e292bd9e8633d6 Regards, Bob Peterson Red Hat File Systems