All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "J. Neuschäfer" <j.ne@posteo.net>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Maxime Ripard <mripard@kernel.org>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: gpio: fairchild,74hc595: Add On Semi MC74HC595A compat
Date: Thu, 2 Jan 2025 12:33:00 -0600	[thread overview]
Message-ID: <20250102183300.GA236291-robh@kernel.org> (raw)
In-Reply-To: <20241224-gpio74-v2-1-bbcf14183191@posteo.net>

On Tue, Dec 24, 2024 at 09:02:10AM +0100, J. Neuschäfer wrote:
> The On Semi MC74HC595A/MC74HCT595A is another part that is compatible with
> the Fairchild MM74HC595. This patch adds it to the DT binding.

To make the binding match what you say here, what you really should have 
is:

compatible = "onnn,74hc595a", "fairchild,74hc595";

And then no driver change is needed (until you have some difference you 
want to handle).

> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
> ---
> 
> v2:
> - Add Linus Walleij's R-b
> ---
>  Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> index e8bc9f018edb1253d700945f006e19598efb299a..629cf9b2ab8e4a63fbe17f56792a46d2066d40c3 100644
> --- a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> +++ b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> @@ -14,6 +14,7 @@ properties:
>      enum:
>        - fairchild,74hc595
>        - nxp,74lvc594
> +      - onnn,74hc595a
>  
>    reg:
>      maxItems: 1
> 
> -- 
> 2.45.2
> 

  reply	other threads:[~2025-01-02 18:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-24  8:02 [PATCH v2 0/3] gpio: 74HC595 / 74x164 shift register improvements J. Neuschäfer
2024-12-24  8:02 ` J. Neuschäfer via B4 Relay
2024-12-24  8:02 ` [PATCH v2 1/3] dt-bindings: gpio: fairchild,74hc595: Add On Semi MC74HC595A compat J. Neuschäfer
2024-12-24  8:02   ` J. Neuschäfer via B4 Relay
2025-01-02 18:33   ` Rob Herring [this message]
2024-12-24  8:02 ` [PATCH v2 2/3] gpio: 74x164: " J. Neuschäfer
2024-12-24  8:02   ` J. Neuschäfer via B4 Relay
2024-12-24  8:02 ` [PATCH v2 3/3] dt-bindings: gpio: fairchild,74hc595: Document chip select vs. latch clock J. Neuschäfer
2024-12-24  8:02   ` J. Neuschäfer via B4 Relay
2024-12-27  8:39   ` Linus Walleij
2025-01-02 18:34   ` Rob Herring (Arm)
2025-01-03 20:33 ` [PATCH v2 0/3] gpio: 74HC595 / 74x164 shift register improvements Bartosz Golaszewski
2025-01-06  9:19   ` Geert Uytterhoeven
2025-01-06 20:16     ` Bartosz Golaszewski
2025-01-08 10:26       ` Csókás Bence
2025-01-08 12:08         ` Bartosz Golaszewski
2025-01-10  0:29           ` J. Neuschäfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250102183300.GA236291-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j.ne@posteo.net \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mripard@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.