From: Fabiano Rosas <farosas@suse.de>
To: qemu-devel@nongnu.org
Cc: Peter Xu <peterx@redhat.com>
Subject: [PULL 7/8] tests/qtest/migration: Re-enable postcopy tests
Date: Thu, 2 Jan 2025 19:06:28 -0300 [thread overview]
Message-ID: <20250102220629.11351-8-farosas@suse.de> (raw)
In-Reply-To: <20250102220629.11351-1-farosas@suse.de>
Postcopy tests have been inadvertently disabled since commit
124a3c58b8 ("tests/qtest/migration: Move ufd_version_check to
utils"). That commit moved the ufd_version_check() function to another
file but failed to make sense of the ifdefs and includes:
The <sys/syscall> include was incorrectly dropped. It is needed to
pull in <asm/unistd.h> for __NR_userfaultfd.
The <sys/ioctl.h> was moved under the wrong ifdef.
Fixes: 124a3c58b8 ("tests/qtest/migration: Move ufd_version_check to utils")
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Message-Id: <20241218192223.10551-2-farosas@suse.de>
---
tests/qtest/migration/migration-util.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/migration/migration-util.c b/tests/qtest/migration/migration-util.c
index 401fe27f00..526bed74ea 100644
--- a/tests/qtest/migration/migration-util.c
+++ b/tests/qtest/migration/migration-util.c
@@ -22,6 +22,11 @@
#include "migration/bootfile.h"
#include "migration/migration-util.h"
+#if defined(__linux__)
+#include <sys/ioctl.h>
+#include <sys/syscall.h>
+#endif
+
/* for uffd_version_check() */
#if defined(__linux__) && defined(__NR_userfaultfd) && defined(CONFIG_EVENTFD)
#include <sys/eventfd.h>
@@ -31,7 +36,6 @@
/* For dirty ring test; so far only x86_64 is supported */
#if defined(__linux__) && defined(HOST_X86_64)
#include "linux/kvm.h"
-#include <sys/ioctl.h>
#endif
--
2.35.3
next prev parent reply other threads:[~2025-01-02 22:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 22:06 [PULL 0/8] QTest patches for 2025-01-02 Fabiano Rosas
2025-01-02 22:06 ` [PULL 1/8] tests/qtest/migration: Fix compile errors when CONFIG_UADK is set Fabiano Rosas
2025-01-02 22:06 ` [PULL 2/8] tests/qtest/migration: Do proper cleanup in the dirty_limit test Fabiano Rosas
2025-01-02 22:06 ` [PULL 3/8] tests/qtest/migration: Initialize buffer in probe_o_direct_support Fabiano Rosas
2025-01-02 22:06 ` [PULL 4/8] tests/qtest/bios-tables-test: Free tables at dump_aml_files Fabiano Rosas
2025-01-02 22:06 ` [PULL 5/8] tests/qtest/virtio-iommu-test: Don't pass uninitialized data into qtest_memwrite Fabiano Rosas
2025-01-02 22:06 ` [PULL 6/8] tests/migration: Drop arch_[source|target] Fabiano Rosas
2025-01-02 22:06 ` Fabiano Rosas [this message]
2025-01-02 22:06 ` [PULL 8/8] qtest/fw-cfg: remove compiled out code Fabiano Rosas
2025-01-03 17:40 ` [PULL 0/8] QTest patches for 2025-01-02 Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250102220629.11351-8-farosas@suse.de \
--to=farosas@suse.de \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.