From: Peter Zijlstra <peterz@infradead.org>
To: Chuyi Zhou <zhouchuyi@bytedance.com>
Cc: mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com, longman@redhat.com, riel@surriel.com,
chengming.zhou@linux.dev, kprateek.nayak@amd.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Take the scheduling domain into account in numa balancin
Date: Fri, 3 Jan 2025 12:36:17 +0100 [thread overview]
Message-ID: <20250103113617.GE22934@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20250103065930.413464-1-zhouchuyi@bytedance.com>
On Fri, Jan 03, 2025 at 02:59:27PM +0800, Chuyi Zhou wrote:
> This patchset tries to adjust the logic of handling isolate cpus in numa balancing.
>
> patch#1: Clean up for task_numa_migrate().
>
> patch#2: Skips the isolate cpus when gathering numa status and finding
> idle cpus in update_numa_stats().
>
> patch#3: Ensure that we do not select an isolated CPU in
> task_numa_find_cpu(), even if it is present in the task's CPU mask.
Your $subject and actual patches do not patch.
Your subject suggests you're taking the scheduling domains into account
for numa balancing, your actual patches are bunch of special case hacks
that totally ignore the actual sched domains :-(
next prev parent reply other threads:[~2025-01-03 11:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 6:59 [PATCH v2 0/3] Take the scheduling domain into account in numa balancin Chuyi Zhou
2025-01-03 6:59 ` [PATCH v2 1/3] sched/fair: Remove unused task_numa_migrate return value Chuyi Zhou
2025-01-05 18:28 ` Madadi Vineeth Reddy
2025-01-03 6:59 ` [PATCH v2 2/3] sched/fair: Ignore isolated cpus in update_numa_stat Chuyi Zhou
2025-01-05 18:52 ` Madadi Vineeth Reddy
2025-01-07 13:16 ` Chuyi Zhou
2025-01-07 18:30 ` Madadi Vineeth Reddy
2025-01-07 18:39 ` Waiman Long
2025-01-08 10:47 ` Chuyi Zhou
2025-01-03 6:59 ` [PATCH v2 3/3] sched/fair: Ensure select housekeeping cpus in task_numa_find_cpu Chuyi Zhou
2025-01-03 11:36 ` Peter Zijlstra [this message]
2025-01-03 12:40 ` [PATCH v2 0/3] Take the scheduling domain into account in numa balancin Chuyi Zhou
2025-01-07 10:48 ` Peter Zijlstra
2025-01-07 13:03 ` Chuyi Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250103113617.GE22934@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=chengming.zhou@linux.dev \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=riel@surriel.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=zhouchuyi@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.