From: Greg KH <gregkh@linuxfoundation.org>
To: Sherry Sun <sherry.sun@nxp.com>
Cc: jirislaby@kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH] tty: serial: fsl_lpuart: increase maximum uart_nr to 12
Date: Fri, 3 Jan 2025 10:08:26 +0100 [thread overview]
Message-ID: <2025010351-overlap-matchless-5c00@gregkh> (raw)
In-Reply-To: <20250103071154.3070924-1-sherry.sun@nxp.com>
On Fri, Jan 03, 2025 at 03:11:54PM +0800, Sherry Sun wrote:
> Some SoCs like the i.MX943 have aliases for up to 12 UARTs, need to
> increase UART_NR from 8 to 12 to support lpuart9-12 to avoid
> initialization failures.
>
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> ---
> drivers/tty/serial/fsl_lpuart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
> index 57b0632a3db6..7cb1e36fdaab 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -245,7 +245,7 @@
>
> #define DRIVER_NAME "fsl-lpuart"
> #define DEV_NAME "ttyLP"
> -#define UART_NR 8
> +#define UART_NR 12
Why not fix this properly and make this dynamic and get rid of the
static array causing all of this problem? That way when you get a
system with 13 uarts, you will be ok :)
thanks,
greg k-h
next prev parent reply other threads:[~2025-01-03 9:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 7:11 [PATCH] tty: serial: fsl_lpuart: increase maximum uart_nr to 12 Sherry Sun
2025-01-03 9:08 ` Greg KH [this message]
2025-01-06 10:24 ` Sherry Sun
2025-01-06 13:44 ` Greg KH
2025-01-07 8:16 ` Sherry Sun
2025-01-07 8:29 ` Sherry Sun
2025-01-07 8:43 ` Greg KH
2025-01-07 9:54 ` Sherry Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025010351-overlap-matchless-5c00@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sherry.sun@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.