From: Damien Le Moal <dlemoal@kernel.org>
To: linux-nvme@lists.infradead.org, "Christoph Hellwig" <hch@lst.de>,
"Keith Busch" <kbusch@kernel.org>,
"Sagi Grimberg" <sagi@grimberg.me>,
linux-pci@vger.kernel.org,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>
Cc: Rick Wertenbroek <rick.wertenbroek@gmail.com>,
Niklas Cassel <cassel@kernel.org>
Subject: [PATCH v9 04/18] nvmet: Introduce nvmet_get_cmd_effects_admin()
Date: Sat, 4 Jan 2025 13:59:37 +0900 [thread overview]
Message-ID: <20250104045951.157830-5-dlemoal@kernel.org> (raw)
In-Reply-To: <20250104045951.157830-1-dlemoal@kernel.org>
In order to have a logically better organized implementation of the
effects log page, split out reporting the supported admin commands from
nvmet_get_cmd_effects_nvm() into the new function
nvmet_get_cmd_effects_admin().
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Tested-by: Rick Wertenbroek <rick.wertenbroek@gmail.com>
Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
drivers/nvme/target/admin-cmd.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
index b73f5fde4d9e..78478a4a2e4d 100644
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/admin-cmd.c
@@ -230,7 +230,7 @@ static void nvmet_execute_get_log_page_smart(struct nvmet_req *req)
nvmet_req_complete(req, status);
}
-static void nvmet_get_cmd_effects_nvm(struct nvme_effects_log *log)
+static void nvmet_get_cmd_effects_admin(struct nvme_effects_log *log)
{
log->acs[nvme_admin_get_log_page] =
log->acs[nvme_admin_identify] =
@@ -240,7 +240,10 @@ static void nvmet_get_cmd_effects_nvm(struct nvme_effects_log *log)
log->acs[nvme_admin_async_event] =
log->acs[nvme_admin_keep_alive] =
cpu_to_le32(NVME_CMD_EFFECTS_CSUPP);
+}
+static void nvmet_get_cmd_effects_nvm(struct nvme_effects_log *log)
+{
log->iocs[nvme_cmd_read] =
log->iocs[nvme_cmd_flush] =
log->iocs[nvme_cmd_dsm] =
@@ -276,6 +279,7 @@ static void nvmet_execute_get_log_cmd_effects_ns(struct nvmet_req *req)
switch (req->cmd->get_log_page.csi) {
case NVME_CSI_NVM:
+ nvmet_get_cmd_effects_admin(log);
nvmet_get_cmd_effects_nvm(log);
break;
case NVME_CSI_ZNS:
@@ -283,6 +287,7 @@ static void nvmet_execute_get_log_cmd_effects_ns(struct nvmet_req *req)
status = NVME_SC_INVALID_IO_CMD_SET;
goto free;
}
+ nvmet_get_cmd_effects_admin(log);
nvmet_get_cmd_effects_nvm(log);
nvmet_get_cmd_effects_zns(log);
break;
--
2.47.1
next prev parent reply other threads:[~2025-01-04 5:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-04 4:59 [PATCH v9 00/18] NVMe PCI endpoint target driver Damien Le Moal
2025-01-04 4:59 ` [PATCH v9 01/18] nvme: Move opcode string helper functions declarations Damien Le Moal
2025-01-04 4:59 ` [PATCH v9 02/18] nvmet: Add vendor_id and subsys_vendor_id subsystem attributes Damien Le Moal
2025-01-04 4:59 ` [PATCH v9 03/18] nvmet: Export nvmet_update_cc() and nvmet_cc_xxx() helpers Damien Le Moal
2025-01-04 4:59 ` Damien Le Moal [this message]
2025-01-04 4:59 ` [PATCH v9 05/18] nvmet: Add drvdata field to struct nvmet_ctrl Damien Le Moal
2025-01-04 4:59 ` [PATCH v9 06/18] nvme: Add PCI transport type Damien Le Moal
2025-01-04 4:59 ` [PATCH v9 07/18] nvmet: Improve nvmet_alloc_ctrl() interface and implementation Damien Le Moal
2025-01-04 4:59 ` [PATCH v9 08/18] nvmet: Introduce nvmet_req_transfer_len() Damien Le Moal
2025-01-04 4:59 ` [PATCH v9 09/18] nvmet: Introduce nvmet_sq_create() and nvmet_cq_create() Damien Le Moal
2025-01-04 4:59 ` [PATCH v9 10/18] nvmet: Add support for I/O queue management admin commands Damien Le Moal
2025-01-04 4:59 ` [PATCH v9 11/18] nvmet: Do not require SGL for PCI target controller commands Damien Le Moal
2025-01-04 4:59 ` [PATCH v9 12/18] nvmet: Introduce get/set_feature controller operations Damien Le Moal
2025-01-04 4:59 ` [PATCH v9 13/18] nvmet: Implement host identifier set feature support Damien Le Moal
2025-01-04 4:59 ` [PATCH v9 14/18] nvmet: Implement interrupt coalescing " Damien Le Moal
2025-01-04 4:59 ` [PATCH v9 15/18] nvmet: Implement interrupt config " Damien Le Moal
2025-01-04 4:59 ` [PATCH v9 16/18] nvmet: Implement arbitration " Damien Le Moal
2025-01-04 4:59 ` [PATCH v9 17/18] nvmet: New NVMe PCI endpoint function target driver Damien Le Moal
2025-01-04 4:59 ` [PATCH v9 18/18] Documentation: Document the NVMe PCI endpoint " Damien Le Moal
2025-01-07 16:47 ` [PATCH v9 00/18] " Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250104045951.157830-5-dlemoal@kernel.org \
--to=dlemoal@kernel.org \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=rick.wertenbroek@gmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.