All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Rafał Miłecki" <rafal@milecki.pl>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: drivers/firmware/broadcom/bcm47xx_nvram.c:61: warning: Function parameter or struct member 'nvram_start' not described in 'bcm47xx_nvram_copy'
Date: Sun, 5 Jan 2025 08:48:14 +0800	[thread overview]
Message-ID: <202501050841.RkMRfS1w-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   ab75170520d4964f3acf8bb1f91d34cbc650688e
commit: 298923cf999cecd2ef06df126f85a3d68da8c4d8 firmware: bcm47xx_nvram: extract code copying NVRAM
date:   3 years, 10 months ago
config: arm-randconfig-r006-20230802 (https://download.01.org/0day-ci/archive/20250105/202501050841.RkMRfS1w-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250105/202501050841.RkMRfS1w-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501050841.RkMRfS1w-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/firmware/broadcom/bcm47xx_nvram.c:41: warning: Function parameter or struct member 'nvram' not described in 'bcm47xx_nvram_is_valid'
>> drivers/firmware/broadcom/bcm47xx_nvram.c:61: warning: Function parameter or struct member 'nvram_start' not described in 'bcm47xx_nvram_copy'
>> drivers/firmware/broadcom/bcm47xx_nvram.c:61: warning: Function parameter or struct member 'res_size' not described in 'bcm47xx_nvram_copy'
   drivers/firmware/broadcom/bcm47xx_nvram.c:85: warning: Function parameter or struct member 'flash_start' not described in 'bcm47xx_nvram_find_and_copy'
   drivers/firmware/broadcom/bcm47xx_nvram.c:85: warning: Function parameter or struct member 'res_size' not described in 'bcm47xx_nvram_find_and_copy'


vim +61 drivers/firmware/broadcom/bcm47xx_nvram.c

    56	
    57	/**
    58	 * bcm47xx_nvram_copy - copy NVRAM to internal buffer
    59	 */
    60	static void bcm47xx_nvram_copy(void __iomem *nvram_start, size_t res_size)
  > 61	{
    62		struct nvram_header __iomem *header = nvram_start;
    63		size_t copy_size;
    64	
    65		copy_size = header->len;
    66		if (copy_size > res_size) {
    67			pr_err("The nvram size according to the header seems to be bigger than the partition on flash\n");
    68			copy_size = res_size;
    69		}
    70		if (copy_size >= NVRAM_SPACE) {
    71			pr_err("nvram on flash (%zu bytes) is bigger than the reserved space in memory, will just copy the first %i bytes\n",
    72			       copy_size, NVRAM_SPACE - 1);
    73			copy_size = NVRAM_SPACE - 1;
    74		}
    75	
    76		__ioread32_copy(nvram_buf, nvram_start, DIV_ROUND_UP(copy_size, 4));
    77		nvram_buf[NVRAM_SPACE - 1] = '\0';
    78		nvram_len = copy_size;
    79	}
    80	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2025-01-05  0:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-05  0:48 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-01-05  0:59 drivers/firmware/broadcom/bcm47xx_nvram.c:61: warning: Function parameter or struct member 'nvram_start' not described in 'bcm47xx_nvram_copy' kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202501050841.RkMRfS1w-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=rafal@milecki.pl \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.