From: Gary Guo <gary@garyguo.net>
To: Danilo Krummrich <dakr@kernel.org>
Cc: gregkh@linuxfoundation.org, rafael@kernel.org, ojeda@kernel.org,
alex.gaynor@gmail.com, boqun.feng@gmail.com,
bjorn3_gh@protonmail.com, benno.lossin@proton.me,
a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu,
bhelgaas@google.com, fujita.tomonori@gmail.com,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 3/3] rust: driver: address soundness issue in `RegistrationOps`
Date: Sun, 5 Jan 2025 19:07:26 +0000 [thread overview]
Message-ID: <20250105190726.30a9131f.gary@garyguo.net> (raw)
In-Reply-To: <20250103164655.96590-4-dakr@kernel.org>
On Fri, 3 Jan 2025 17:46:03 +0100
Danilo Krummrich <dakr@kernel.org> wrote:
> The `RegistrationOps` trait holds some obligations to the caller and
> implementers. While being documented, the trait and the corresponding
> functions haven't been marked as unsafe.
>
> Hence, markt the trait and functions unsafe and add the corresponding
> safety comments.
nit: markt -> mark
>
> This patch does not include any fuctional changes.
>
> Reported-by: Gary Guo <gary@garyguo.net>
> Closes: https://lore.kernel.org/rust-for-linux/20241224195821.3b43302b.gary@garyguo.net/
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>
Reviewed-by: Gary Guo <gary@garyguo.net>
> ---
> rust/kernel/driver.rs | 25 ++++++++++++++++++++-----
> rust/kernel/pci.rs | 8 +++++---
> rust/kernel/platform.rs | 8 +++++---
> 3 files changed, 30 insertions(+), 11 deletions(-)
prev parent reply other threads:[~2025-01-05 19:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 16:46 [PATCH 0/3] Fixes for Rust Device / Driver abstractions Danilo Krummrich
2025-01-03 16:46 ` [PATCH 1/3] rust: pci: do not depend on CONFIG_PCI_MSI Danilo Krummrich
2025-01-07 10:31 ` Greg KH
2025-01-07 10:41 ` Danilo Krummrich
2025-01-03 16:46 ` [PATCH 2/3] rust: io: move module entry to its correct location Danilo Krummrich
2025-01-03 16:46 ` [PATCH 3/3] rust: driver: address soundness issue in `RegistrationOps` Danilo Krummrich
2025-01-05 19:07 ` Gary Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250105190726.30a9131f.gary@garyguo.net \
--to=gary@garyguo.net \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.