From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Ming Lei <ming.lei@redhat.com>,
Nilay Shroff <nilay@linux.ibm.com>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
nbd@other.debian.org, virtualization@lists.linux.dev,
linux-scsi@vger.kernel.org, usb-storage@lists.one-eyed-alien.net
Subject: Re: [PATCH 06/10] virtio_blk: use queue_limits_commit_update_frozen in cache_type_store
Date: Mon, 6 Jan 2025 11:59:57 +0100 [thread overview]
Message-ID: <20250106105957.GC21833@lst.de> (raw)
In-Reply-To: <07353499-b62d-488a-9575-12de5d9b6f2e@kernel.org>
On Mon, Jan 06, 2025 at 07:56:19PM +0900, Damien Le Moal wrote:
> On 1/6/25 7:06 PM, Christoph Hellwig wrote:
> > So far cache_type_store didn't freeze the queue, fix that by using the
> > queue_limits_commit_update_frozen helper.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> This should be squashed in patch 2, no ?
patch 2 is supposed to just be a mechanical conversion, and each
behavior change should be in it's own patch.
next prev parent reply other threads:[~2025-01-06 11:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 10:06 RFC: fix queue freeze and limit locking order (alt take) Christoph Hellwig
2025-01-06 10:06 ` [PATCH 01/10] block: fix docs for freezing of queue limits updates Christoph Hellwig
2025-01-06 10:39 ` Damien Le Moal
2025-01-06 10:06 ` [PATCH 02/10] block: add a queue_limits_commit_update_frozen helper Christoph Hellwig
2025-01-06 10:41 ` Damien Le Moal
2025-01-06 10:06 ` [PATCH 03/10] block: add a store_limit operations for sysfs entries Christoph Hellwig
2025-01-06 10:46 ` Damien Le Moal
2025-01-06 10:57 ` Christoph Hellwig
2025-01-06 10:06 ` [PATCH 04/10] block: use queue_limits_commit_update in queue_attr_store Christoph Hellwig
2025-01-06 10:48 ` Damien Le Moal
2025-01-06 10:06 ` [PATCH 05/10] block: don't update BLK_FEAT_POLL in __blk_mq_update_nr_hw_queues Christoph Hellwig
2025-01-06 10:55 ` Damien Le Moal
2025-01-06 10:59 ` Christoph Hellwig
2025-01-06 11:01 ` Nilay Shroff
2025-01-06 11:05 ` Christoph Hellwig
2025-01-06 12:06 ` Nilay Shroff
2025-01-06 15:27 ` Christoph Hellwig
2025-01-07 7:06 ` Nilay Shroff
2025-01-06 10:06 ` [PATCH 06/10] virtio_blk: use queue_limits_commit_update_frozen in cache_type_store Christoph Hellwig
2025-01-06 10:56 ` Damien Le Moal
2025-01-06 10:59 ` Christoph Hellwig [this message]
2025-01-06 13:09 ` Damien Le Moal
2025-01-06 15:27 ` Christoph Hellwig
2025-01-06 10:06 ` [PATCH 07/10] usb-storage: use queue_limits_commit_update_frozen in max_sectors_store Christoph Hellwig
2025-01-06 10:06 ` [PATCH 08/10] nvme: freeze queue after taking limits lock Christoph Hellwig
2025-01-06 10:06 ` [PATCH 09/10] loop: document why loop_clear_limits updates queue limits without freezing Christoph Hellwig
2025-01-06 10:06 ` [PATCH 10/10] nbd: use queue_limits_commit_update_frozen in nbd_set_size Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106105957.GC21833@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nbd@other.debian.org \
--cc=nilay@linux.ibm.com \
--cc=usb-storage@lists.one-eyed-alien.net \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.