From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] runtest/ltp-aiodio.part4: Remove duplicate entries
Date: Mon, 6 Jan 2025 15:16:35 +0100 [thread overview]
Message-ID: <20250106141635.GA323533@pevik> (raw)
In-Reply-To: <119d081a-f1cc-400f-a278-27e6e33495ac@suse.com>
> Hi Petr,
> On 1/6/25 15:04, Petr Vorel wrote:
> > Duplicate content was added in 67ce2884aa (2006).
> > It probably did not make sense to run it more times even at the time,
> > but it certainly does not make sense now (runltp and kirk run tests
> > sequentially one by one).
> > While at it, remove bogus comments.
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > runtest/ltp-aiodio.part4 | 55 ++--------------------------------------
> > 1 file changed, 2 insertions(+), 53 deletions(-)
> > diff --git a/runtest/ltp-aiodio.part4 b/runtest/ltp-aiodio.part4
> > index de00b8a786..8e7354296d 100644
> > --- a/runtest/ltp-aiodio.part4
> > +++ b/runtest/ltp-aiodio.part4
> > @@ -1,65 +1,14 @@
> > aio01 aio01
> > aio02 aio02
> > -#Running dio_sparse & dirty tests
> > DI000 dirty
> > DS000 dio_sparse
> Uhm, I remember that we discussed with Cyril about it in the past. The dirty
> test was made in order to stress IO before dio_sparse if I'm not wrong.
Andrea, thanks for info.
@Cyril? If relevant maybe we should just document it. Does it apply to all
duplicates? I wonder if it makes sense to run whole runset for 45 min when we
are testing something mainline does not care about it's performance.
https://lore.kernel.org/ltp/20240722090012.mlvkaenuxar2x3vr@quack3/
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-01-06 14:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 14:04 [LTP] [PATCH 1/1] runtest/ltp-aiodio.part4: Remove duplicate entries Petr Vorel
2025-01-06 14:12 ` Andrea Cervesato via ltp
2025-01-06 14:16 ` Petr Vorel [this message]
2025-01-07 10:43 ` Cyril Hrubis
2025-01-07 11:33 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106141635.GA323533@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.