From: Jakub Kicinski <kuba@kernel.org>
To: Benjamin Coddington <bcodding@redhat.com>
Cc: Boris Pismenny <borisp@nvidia.com>,
John Fastabend <john.fastabend@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] tls: Fix tls_sw_sendmsg error handling
Date: Mon, 6 Jan 2025 18:36:33 -0800 [thread overview]
Message-ID: <20250106183633.0ddb7cb0@kernel.org> (raw)
In-Reply-To: <9594185559881679d81f071b181a10eb07cd079f.1736004079.git.bcodding@redhat.com>
On Sat, 4 Jan 2025 10:29:45 -0500 Benjamin Coddington wrote:
> We've noticed that NFS can hang when using RPC over TLS on an unstable
> connection, and investigation shows that the RPC layer is stuck in a tight
> loop attempting to transmit, but forever getting -EBADMSG back from the
> underlying network. The loop begins when tcp_sendmsg_locked() returns
> -EPIPE to tls_tx_records(), but that error is converted to -EBADMSG when
> calling the socket's error reporting handler.
>
> Instead of converting errors from tcp_sendmsg_locked(), let's pass them
> along in this path. The RPC layer handles -EPIPE by reconnecting the
> transport, which prevents the endless attempts to transmit on a broken
> connection.
LGTM, only question in my mind is whether we should send this to stable.
Any preference?
next prev parent reply other threads:[~2025-01-07 2:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-04 15:29 [PATCH] tls: Fix tls_sw_sendmsg error handling Benjamin Coddington
2025-01-07 2:36 ` Jakub Kicinski [this message]
2025-01-07 12:28 ` Benjamin Coddington
2025-01-08 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106183633.0ddb7cb0@kernel.org \
--to=kuba@kernel.org \
--cc=bcodding@redhat.com \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.