From: kernel test robot <lkp@intel.com>
To: Hongzhen Luo <hongzhen@linux.alibaba.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC PATCH v5 4/4] erofs: introduce .fadvise for page cache share
Date: Mon, 6 Jan 2025 19:52:34 +0800 [thread overview]
Message-ID: <202501061957.awS07N4f-lkp@intel.com> (raw)
In-Reply-To: <20250105151208.3797385-5-hongzhen@linux.alibaba.com>
Hi Hongzhen,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:
[auto build test WARNING on xiang-erofs/dev-test]
[also build test WARNING on xiang-erofs/dev xiang-erofs/fixes linus/master v6.13-rc6 next-20250106]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Hongzhen-Luo/erofs-move-struct-erofs_anon_fs_type-to-super-c/20250105-231438
base: https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git dev-test
patch link: https://lore.kernel.org/r/20250105151208.3797385-5-hongzhen%40linux.alibaba.com
patch subject: [RFC PATCH v5 4/4] erofs: introduce .fadvise for page cache share
config: arc-allmodconfig (https://download.01.org/0day-ci/archive/20250106/202501061957.awS07N4f-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250106/202501061957.awS07N4f-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501061957.awS07N4f-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from fs/erofs/pagecache_share.c:10:
fs/erofs/pagecache_share.c: In function 'erofs_pcshr_init_mnt':
fs/erofs/pagecache_share.c:66:32: error: invalid application of 'sizeof' to incomplete type 'struct interval_tree_node'
66 | sizeof(struct interval_tree_node), 0,
| ^~~~~~
include/linux/slab.h:430:55: note: in definition of macro 'kmem_cache_create'
430 | default: __kmem_cache_create)(__name, __object_size, __args, __VA_ARGS__)
| ^~~~~~~~~~~~~
fs/erofs/pagecache_share.c: In function 'erofs_pcshr_free_inode':
fs/erofs/pagecache_share.c:163:15: error: implicit declaration of function 'interval_tree_iter_first'; did you mean 'vma_interval_tree_iter_first'? [-Werror=implicit-function-declaration]
163 | seg = interval_tree_iter_first(&vi->segs, 0, LLONG_MAX);
| ^~~~~~~~~~~~~~~~~~~~~~~~
| vma_interval_tree_iter_first
>> fs/erofs/pagecache_share.c:163:13: warning: assignment to 'struct interval_tree_node *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
163 | seg = interval_tree_iter_first(&vi->segs, 0, LLONG_MAX);
| ^
fs/erofs/pagecache_share.c:165:28: error: implicit declaration of function 'interval_tree_iter_next'; did you mean 'vma_interval_tree_iter_next'? [-Werror=implicit-function-declaration]
165 | next_seg = interval_tree_iter_next(seg, 0, LLONG_MAX);
| ^~~~~~~~~~~~~~~~~~~~~~~
| vma_interval_tree_iter_next
fs/erofs/pagecache_share.c:165:26: warning: assignment to 'struct interval_tree_node *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
165 | next_seg = interval_tree_iter_next(seg, 0, LLONG_MAX);
| ^
fs/erofs/pagecache_share.c:166:17: error: implicit declaration of function 'interval_tree_remove'; did you mean 'vma_interval_tree_remove'? [-Werror=implicit-function-declaration]
166 | interval_tree_remove(seg, &vi->segs);
| ^~~~~~~~~~~~~~~~~~~~
| vma_interval_tree_remove
fs/erofs/pagecache_share.c: In function 'erofs_pcshr_fadvise':
fs/erofs/pagecache_share.c:276:13: warning: assignment to 'struct interval_tree_node *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
276 | seg = interval_tree_iter_first(&vi->segs, start, end);
| ^
fs/erofs/pagecache_share.c:278:26: warning: assignment to 'struct interval_tree_node *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
278 | next_seg = interval_tree_iter_next(seg, start, end);
| ^
In file included from include/linux/kernel.h:28,
from include/linux/cpumask.h:11,
from include/linux/smp.h:13,
from include/linux/lockdep.h:14,
from include/linux/mutex.h:17,
from fs/erofs/pagecache_share.c:8:
fs/erofs/pagecache_share.c:283:35: error: invalid use of undefined type 'struct interval_tree_node'
283 | l = max_t(u64, seg->start | 0ULL, start);
| ^~
include/linux/minmax.h:93:23: note: in definition of macro '__cmp_once_unique'
93 | ({ type ux = (x); type uy = (y); __cmp(op, ux, uy); })
| ^
include/linux/minmax.h:221:27: note: in expansion of macro '__cmp_once'
221 | #define max_t(type, x, y) __cmp_once(max, type, x, y)
| ^~~~~~~~~~
fs/erofs/pagecache_share.c:283:21: note: in expansion of macro 'max_t'
283 | l = max_t(u64, seg->start | 0ULL, start);
| ^~~~~
fs/erofs/pagecache_share.c:284:35: error: invalid use of undefined type 'struct interval_tree_node'
284 | r = min_t(u64, seg->last | 0ULL, end);
| ^~
include/linux/minmax.h:93:23: note: in definition of macro '__cmp_once_unique'
93 | ({ type ux = (x); type uy = (y); __cmp(op, ux, uy); })
| ^
include/linux/minmax.h:213:27: note: in expansion of macro '__cmp_once'
213 | #define min_t(type, x, y) __cmp_once(min, type, x, y)
| ^~~~~~~~~~
fs/erofs/pagecache_share.c:284:21: note: in expansion of macro 'min_t'
284 | r = min_t(u64, seg->last | 0ULL, end);
| ^~~~~
fs/erofs/pagecache_share.c:289:24: error: invalid use of undefined type 'struct interval_tree_node'
289 | if (seg->start < l) {
| ^~
fs/erofs/pagecache_share.c:291:32: error: invalid use of undefined type 'struct interval_tree_node'
291 | new_seg->start = seg->start;
| ^~
fs/erofs/pagecache_share.c:291:45: error: invalid use of undefined type 'struct interval_tree_node'
291 | new_seg->start = seg->start;
| ^~
fs/erofs/pagecache_share.c:292:32: error: invalid use of undefined type 'struct interval_tree_node'
292 | new_seg->last = l;
| ^~
fs/erofs/pagecache_share.c:293:25: error: implicit declaration of function 'interval_tree_insert'; did you mean 'vma_interval_tree_insert'? [-Werror=implicit-function-declaration]
293 | interval_tree_insert(new_seg, &vi->segs);
| ^~~~~~~~~~~~~~~~~~~~
| vma_interval_tree_insert
fs/erofs/pagecache_share.c:297:28: error: invalid use of undefined type 'struct interval_tree_node'
297 | if (r < seg->last) {
| ^~
fs/erofs/pagecache_share.c:299:32: error: invalid use of undefined type 'struct interval_tree_node'
299 | new_seg->start = r;
| ^~
fs/erofs/pagecache_share.c:300:32: error: invalid use of undefined type 'struct interval_tree_node'
300 | new_seg->last = seg->last;
| ^~
fs/erofs/pagecache_share.c:300:44: error: invalid use of undefined type 'struct interval_tree_node'
300 | new_seg->last = seg->last;
| ^~
fs/erofs/pagecache_share.c: In function 'erofs_pcshr_read_end':
fs/erofs/pagecache_share.c:367:12: error: invalid use of undefined type 'struct interval_tree_node'
367 | seg->start = folio_index(folio);
| ^~
fs/erofs/pagecache_share.c:368:12: error: invalid use of undefined type 'struct interval_tree_node'
368 | seg->last = seg->start + (folio_size(folio) >> PAGE_SHIFT);
| ^~
fs/erofs/pagecache_share.c:368:24: error: invalid use of undefined type 'struct interval_tree_node'
368 | seg->last = seg->start + (folio_size(folio) >> PAGE_SHIFT);
| ^~
fs/erofs/pagecache_share.c:369:16: error: invalid use of undefined type 'struct interval_tree_node'
369 | if (seg->last > (vi->vfs_inode.i_size >> PAGE_SHIFT))
| ^~
fs/erofs/pagecache_share.c:370:20: error: invalid use of undefined type 'struct interval_tree_node'
370 | seg->last = vi->vfs_inode.i_size >> PAGE_SHIFT;
| ^~
In file included from arch/arc/include/asm/atomic.h:12,
from include/linux/atomic.h:7,
from include/linux/refcount.h:95,
from fs/erofs/pagecache_share.c:6:
fs/erofs/pagecache_share.c:371:22: error: invalid use of undefined type 'struct interval_tree_node'
371 | DBG_BUGON(seg->last < seg->start);
vim +163 fs/erofs/pagecache_share.c
153
154 void erofs_pcshr_free_inode(struct inode *inode)
155 {
156 struct interval_tree_node *seg, *next_seg;
157 struct erofs_inode *vi = EROFS_I(inode);
158
159 if (S_ISREG(inode->i_mode) && vi->ano_inode) {
160 iput(vi->ano_inode);
161 vi->ano_inode = NULL;
162 }
> 163 seg = interval_tree_iter_first(&vi->segs, 0, LLONG_MAX);
164 while (seg) {
165 next_seg = interval_tree_iter_next(seg, 0, LLONG_MAX);
166 interval_tree_remove(seg, &vi->segs);
167 erofs_pcshr_free_seg(seg);
168 seg = next_seg;
169 }
170 }
171
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2025-01-06 11:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-05 15:12 [RFC PATCH v5 0/4] erofs: page cache share feature Hongzhen Luo
2025-01-05 15:12 ` Hongzhen Luo
2025-01-05 15:12 ` [RFC PATCH v5 1/4] erofs: move `struct erofs_anon_fs_type` to super.c Hongzhen Luo
2025-01-05 15:12 ` Hongzhen Luo
2025-01-05 15:12 ` [RFC PATCH v5 2/4] erofs: introduce the page cache share feature Hongzhen Luo
2025-01-05 15:12 ` Hongzhen Luo
2025-01-06 2:27 ` Gao Xiang
2025-01-06 3:03 ` Hongzhen Luo
2025-01-05 15:12 ` [RFC PATCH v5 3/4] erofs: apply " Hongzhen Luo
2025-01-05 15:12 ` Hongzhen Luo
2025-01-06 2:15 ` Gao Xiang
2025-01-21 11:59 ` Hongbo Li via Linux-erofs
2025-01-21 11:59 ` Hongbo Li
2025-01-21 12:16 ` Gao Xiang
2025-01-21 14:48 ` Hongzhen Luo
2025-01-05 15:12 ` [RFC PATCH v5 4/4] erofs: introduce .fadvise for page cache share Hongzhen Luo
2025-01-05 15:12 ` Hongzhen Luo
2025-01-05 18:52 ` kernel test robot
2025-01-06 3:40 ` kernel test robot
2025-01-06 11:52 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202501061957.awS07N4f-lkp@intel.com \
--to=lkp@intel.com \
--cc=hongzhen@linux.alibaba.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.