From: Jakub Kicinski <kuba@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Mateusz Polchlopek <mateusz.polchlopek@intel.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Simon Horman <horms@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next v5 6/8] ethtool: add helper to prevent invalid statistics exposure to userspace
Date: Tue, 7 Jan 2025 18:05:00 -0800 [thread overview]
Message-ID: <20250107180500.34be6ded@kernel.org> (raw)
In-Reply-To: <20250106083301.1039850-7-o.rempel@pengutronix.de>
On Mon, 6 Jan 2025 09:32:59 +0100 Oleksij Rempel wrote:
> Introduce a new helper function, `ethtool_stat_add`, to update 64-bit
> statistics with proper handling of the reserved value
> `ETHTOOL_STAT_NOT_SET`. This ensures that statistics remain valid and
> are always reported to userspace, even if the driver accidentally sets
> `ETHTOOL_STAT_NOT_SET` during an update.
u64 can't wrap. If it could we should be using a wider type
to count packets/bytes. I don't see the need for this, sorry
for missing the discussion.
next prev parent reply other threads:[~2025-01-08 2:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 8:32 [PATCH net-next v5 0/8] Introduce unified and structured PHY Oleksij Rempel
2025-01-06 8:32 ` [PATCH net-next v5 1/8] ethtool: linkstate: migrate linkstate functions to support multi-PHY setups Oleksij Rempel
2025-01-06 8:32 ` [PATCH net-next v5 2/8] net: ethtool: plumb PHY stats to PHY drivers Oleksij Rempel
2025-01-08 2:02 ` Jakub Kicinski
2025-01-08 9:08 ` Oleksij Rempel
2025-01-08 16:03 ` Andrew Lunn
2025-01-08 16:24 ` Maxime Chevallier
2025-01-08 17:47 ` Jakub Kicinski
2025-01-06 8:32 ` [PATCH net-next v5 3/8] net: ethtool: add support for structured PHY statistics Oleksij Rempel
2025-01-06 8:32 ` [PATCH net-next v5 4/8] Documentation: networking: update PHY error counter diagnostics in twisted pair guide Oleksij Rempel
2025-01-06 8:32 ` [PATCH net-next v5 5/8] net: phy: introduce optional polling interface for PHY statistics Oleksij Rempel
2025-01-06 8:32 ` [PATCH net-next v5 6/8] ethtool: add helper to prevent invalid statistics exposure to userspace Oleksij Rempel
2025-01-08 2:05 ` Jakub Kicinski [this message]
2025-01-06 8:33 ` [PATCH net-next v5 7/8] net: phy: dp83td510: add statistics support Oleksij Rempel
2025-01-06 8:33 ` [PATCH net-next v5 8/8] net: phy: dp83tg720: " Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250107180500.34be6ded@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mateusz.polchlopek@intel.com \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.