All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rorie Reyes <rreyes@linux.ibm.com>
To: qemu-devel@nongnu.org, qemu-s390x@nongnu.org
Cc: pbonzini@redhat.com, cohuck@redhat.com, pasic@linux.ibm.com,
	jjherne@linux.ibm.com, borntraeger@linux.ibm.com,
	alex.williamson@redhat.com, clg@redhat.com, thuth@redhat.com,
	akrowiak@linux.ibm.com
Subject: [PATCH v1 2/5] hw/vfio/ap: notification handler for AP config changed event
Date: Tue,  7 Jan 2025 13:43:51 -0500	[thread overview]
Message-ID: <20250107184354.91079-3-rreyes@linux.ibm.com> (raw)
In-Reply-To: <20250107184354.91079-1-rreyes@linux.ibm.com>

Register an event notifier handler to process AP configuration
change events by queuing the event and generating a CRW to let
the guest know its AP configuration has changed

Signed-off-by: Rorie Reyes <rreyes@linux.ibm.com>
Reviewed-by: Anthony Krowiak <akrowiak@linux.ibm.com>
Tested-by: Anthony Krowiak <akrowiak@linux.ibm.com>
---
 hw/vfio/ap.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index 30b08ad375..533cadb2dd 100644
--- a/hw/vfio/ap.c
+++ b/hw/vfio/ap.c
@@ -18,6 +18,7 @@
 #include "hw/vfio/vfio-common.h"
 #include "system/iommufd.h"
 #include "hw/s390x/ap-device.h"
+#include "hw/s390x/css.h"
 #include "qemu/error-report.h"
 #include "qemu/event_notifier.h"
 #include "qemu/main-loop.h"
@@ -37,6 +38,7 @@ struct VFIOAPDevice {
     APDevice apdev;
     VFIODevice vdev;
     EventNotifier req_notifier;
+    EventNotifier cfg_notifier;
 };
 
 OBJECT_DECLARE_SIMPLE_TYPE(VFIOAPDevice, VFIO_AP_DEVICE)
@@ -70,6 +72,18 @@ static void vfio_ap_req_notifier_handler(void *opaque)
     }
 }
 
+static void vfio_ap_cfg_chg_notifier_handler(void *opaque)
+{
+    VFIOAPDevice *vapdev = opaque;
+
+    if (!event_notifier_test_and_clear(&vapdev->cfg_notifier)) {
+        warn_report("Event notifier not initialized");
+        return;
+    }
+
+    css_generate_css_crws(0);
+}
+
 static bool vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev,
                                           unsigned int irq, Error **errp)
 {
@@ -85,6 +99,10 @@ static bool vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev,
         notifier = &vapdev->req_notifier;
         fd_read = vfio_ap_req_notifier_handler;
         break;
+    case VFIO_AP_CFG_CHG_IRQ_INDEX:
+        notifier = &vapdev->cfg_notifier;
+        fd_read = vfio_ap_cfg_chg_notifier_handler;
+        break;
     default:
         error_setg(errp, "vfio: Unsupported device irq(%d)", irq);
         return false;
@@ -175,6 +193,15 @@ static void vfio_ap_realize(DeviceState *dev, Error **errp)
         warn_report_err(err);
     }
 
+    if (!vfio_ap_register_irq_notifier(vapdev, VFIO_AP_CFG_CHG_IRQ_INDEX, &err))
+    {
+        /*
+         * Report this error, but do not make it a failing condition.
+         * Lack of this IRQ in the host does not prevent normal operation.
+         */
+        warn_report_err(err);
+    }
+
     return;
 
 error:
-- 
2.39.5 (Apple Git-154)



  parent reply	other threads:[~2025-01-07 21:00 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-07 18:43 [PATCH v1 0/5] Report vfio-ap configuration changes Rorie Reyes
2025-01-07 18:43 ` [PATCH v1 1/5] linux-headers: NOTFORMERGE - placeholder uapi updates for AP config change Rorie Reyes
2025-01-08  7:29   ` Cédric Le Goater
2025-01-14 18:51     ` Rorie Reyes
2025-01-14 19:55       ` Eric Farman
2025-01-24  8:49         ` Cédric Le Goater
2025-01-24 14:45           ` Eric Farman
2025-01-07 18:43 ` Rorie Reyes [this message]
2025-01-08  7:34   ` [PATCH v1 2/5] hw/vfio/ap: notification handler for AP config changed event Cédric Le Goater
2025-01-08 18:58     ` Rorie Reyes
2025-01-15 17:00   ` Anthony Krowiak
2025-01-24  8:31   ` Cédric Le Goater
2025-01-07 18:43 ` [PATCH v1 3/5] hw/vfio/ap: store object indicating AP config changed in a queue Rorie Reyes
2025-01-24  8:37   ` Cédric Le Goater
2025-01-27 19:12   ` Anthony Krowiak
2025-02-03 16:50   ` Anthony Krowiak
2025-02-04 13:22     ` Rorie Reyes
2025-01-07 18:43 ` [PATCH v1 4/5] hw/vfio/ap: Storing event information for an AP configuration change event Rorie Reyes
2025-01-24  8:43   ` Cédric Le Goater
2025-01-07 18:43 ` [PATCH v1 5/5] s390: implementing CHSC SEI for AP config change Rorie Reyes
2025-01-07 19:06 ` [PATCH v1 0/5] Report vfio-ap configuration changes Alex Williamson
2025-01-14 16:34   ` Rorie Reyes
2025-02-05 17:38   ` Rorie Reyes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250107184354.91079-3-rreyes@linux.ibm.com \
    --to=rreyes@linux.ibm.com \
    --cc=akrowiak@linux.ibm.com \
    --cc=alex.williamson@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=clg@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=jjherne@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.