From: Stephen Hemminger <stephen@networkplumber.org>
To: Mike Bly <bly454@gmail.com>
Cc: dev@dpdk.org, stable@dpdk.org, jgrajcia@cisco.com
Subject: Re: [PATCH v2] net/memif: Fix memif-rx buffer linking
Date: Wed, 8 Jan 2025 07:36:41 -0800 [thread overview]
Message-ID: <20250108073641.5e9d89e3@pi5> (raw)
In-Reply-To: <CAB3eHOwcEg_7A1rsDFm7QuGQXd72XscEkxg0PcgkUqe8-ZVP-A@mail.gmail.com>
On Tue, 7 Jan 2025 10:22:10 -0800
Mike Bly <bly454@gmail.com> wrote:
> Cc: stable@dpdk.org, jgrajcia@cisco.com
> Subject: [PATCH v2] net/memif: Fix memif-rx buffer linking
> Date: Tue, 7 Jan 2025 10:22:10 -0800
>
> Moving where dst_off is set in memif-rx function. It should be
> initialized for each new dpdk-mbuf, not each memif-buffer.
> Bugzilla ID: 1609
> Fixes: aa17df860891 ("net/memif: add a Rx fast path")
> Cc: stable@dpdk.org
> Cc: Jakub Grajciar <jgrajcia@cisco.com>
>
> Signed-off-by: Mike Bly <bly454@gmail.com>
> ---
> drivers/net/memif/rte_eth_memif.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/memif/rte_eth_memif.c
> b/drivers/net/memif/rte_eth_memif.c
> index c0bf1e3bbf..bef1606550 100644
> --- a/drivers/net/memif/rte_eth_memif.c
> +++ b/drivers/net/memif/rte_eth_memif.c
> @@ -414,13 +414,12 @@ eth_memif_rx(void *queue, struct rte_mbuf **bufs,
> uint16_t nb_pkts)
> goto no_free_bufs;
> mbuf = mbuf_head;
> mbuf->port = mq->in_port;
> -
> + dst_off = 0;
> next_slot2:
> s0 = cur_slot & mask;
> d0 = &ring->desc[s0];
Looks like mailer whitespace corruption again.
next prev parent reply other threads:[~2025-01-08 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 18:22 [PATCH v2] net/memif: Fix memif-rx buffer linking Mike Bly
2025-01-08 15:36 ` Stephen Hemminger [this message]
2026-03-16 8:49 ` Sriram Yagnaraman
2026-03-16 15:13 ` Mike Bly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250108073641.5e9d89e3@pi5 \
--to=stephen@networkplumber.org \
--cc=bly454@gmail.com \
--cc=dev@dpdk.org \
--cc=jgrajcia@cisco.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.