All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Stefan Hajnoczi" <stefanha@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: [PULL 06/14] hw/s390x/ipl: Remove the "iplbext_migration" property
Date: Wed,  8 Jan 2025 09:45:03 +0100	[thread overview]
Message-ID: <20250108084511.238458-7-thuth@redhat.com> (raw)
In-Reply-To: <20250108084511.238458-1-thuth@redhat.com>

Now that the old machine types that used this property have been
removed, we can remove the property and the corresponding code.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Acked-by: Christian Borntraeger <borntraeger@linux.ibm.com>
Message-ID: <20250103144232.520383-6-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/s390x/ipl.h |  1 -
 hw/s390x/ipl.c | 10 ----------
 2 files changed, 11 deletions(-)

diff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h
index d7d0b7bfd2..8e3882d506 100644
--- a/hw/s390x/ipl.h
+++ b/hw/s390x/ipl.h
@@ -80,7 +80,6 @@ struct S390IPLState {
     uint8_t cssid;
     uint8_t ssid;
     uint16_t devno;
-    bool iplbext_migration;
 };
 QEMU_BUILD_BUG_MSG(offsetof(S390IPLState, iplb) & 3, "alignment of iplb wrong");
 
diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
index 3a946be7a5..4aa21c91fc 100644
--- a/hw/s390x/ipl.c
+++ b/hw/s390x/ipl.c
@@ -49,13 +49,6 @@
 #define BIOS_MAX_SIZE                   0x300000UL
 #define IPL_PSW_MASK                    (PSW_MASK_32 | PSW_MASK_64)
 
-static bool iplb_extended_needed(void *opaque)
-{
-    S390IPLState *ipl = S390_IPL(object_resolve_path(TYPE_S390_IPL, NULL));
-
-    return ipl->iplbext_migration;
-}
-
 /* Place the IPLB chain immediately before the BIOS in memory */
 static uint64_t find_iplb_chain_addr(uint64_t bios_addr, uint16_t count)
 {
@@ -67,7 +60,6 @@ static const VMStateDescription vmstate_iplb_extended = {
     .name = "ipl/iplb_extended",
     .version_id = 0,
     .minimum_version_id = 0,
-    .needed = iplb_extended_needed,
     .fields = (const VMStateField[]) {
         VMSTATE_UINT8_ARRAY(reserved_ext, IplParameterBlock, 4096 - 200),
         VMSTATE_END_OF_LIST()
@@ -297,8 +289,6 @@ static const Property s390_ipl_properties[] = {
     DEFINE_PROP_STRING("cmdline", S390IPLState, cmdline),
     DEFINE_PROP_STRING("firmware", S390IPLState, firmware),
     DEFINE_PROP_BOOL("enforce_bios", S390IPLState, enforce_bios, false),
-    DEFINE_PROP_BOOL("iplbext_migration", S390IPLState, iplbext_migration,
-                     true),
 };
 
 static void s390_ipl_set_boot_menu(S390IPLState *ipl)
-- 
2.47.1



  parent reply	other threads:[~2025-01-08  8:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-08  8:44 [PULL 00/14] Fixes for tests and removal of deprecated features Thomas Huth
2025-01-08  8:44 ` [PULL 01/14] tests/tcg/s390x: Use the SLOF libc headers for the multiarch tests Thomas Huth
2025-01-08  8:44 ` [PULL 02/14] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.4 and 2.5 machine types Thomas Huth
2025-01-08  8:45 ` [PULL 03/14] hw/s390x/s390-skeys: Remove the "migration-enabled" property Thomas Huth
2025-01-08  8:45 ` [PULL 04/14] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.6 machine type Thomas Huth
2025-01-08  8:45 ` [PULL 05/14] hw/s390x: Remove the "ri_allowed" switch Thomas Huth
2025-01-08  8:45 ` Thomas Huth [this message]
2025-01-08  8:45 ` [PULL 07/14] hw/s390x/css-bridge: Remove the "css_dev_path" property Thomas Huth
2025-01-08  8:45 ` [PULL 08/14] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.7 machine type Thomas Huth
2025-01-08  8:45 ` [PULL 09/14] hw/s390x: Remove the cpu_model_allowed flag and related code Thomas Huth
2025-01-08  8:45 ` [PULL 10/14] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.8 machine type Thomas Huth
2025-01-08  8:45 ` [PULL 11/14] hw/s390x: Remove the "adapter_routes_max_batch" property from the flic Thomas Huth
2025-01-08  8:45 ` [PULL 12/14] Remove the deprecated "-runas" command line option Thomas Huth
2025-01-08  8:45 ` [PULL 13/14] docs/about/deprecated: Remove paragraph about initial deprecation in 2.10 Thomas Huth
2025-01-08  8:45 ` [PULL 14/14] tests/functional/test_x86_64_hotplug_cpu: Fix race condition during unplug Thomas Huth
2025-01-08 19:14 ` [PULL 00/14] Fixes for tests and removal of deprecated features Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250108084511.238458-7-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.