From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22F95E77188 for ; Wed, 8 Jan 2025 11:11:24 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 825218006D; Wed, 8 Jan 2025 12:11:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gentoo.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id DF66A800D7; Wed, 8 Jan 2025 12:11:21 +0100 (CET) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9A29080040 for ; Wed, 8 Jan 2025 12:11:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gentoo.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=dlan@gentoo.org Date: Wed, 8 Jan 2025 19:11:05 +0800 From: Yixun Lan To: Huan Zhou Cc: u-boot@lists.denx.de, Ben Dooks , Marcel Ziswiler , Bin Meng , Dan Carpenter , Frieder Schrempf , Heinrich Schuchardt , Jonas =?iso-8859-1?Q?Schw=F6bel?= , Kever Yang , Leo , Michal Simek , Nishanth Menon , Quentin Schulz , Randolph , Rick Chen , Samuel Holland , Sumit Garg , Svyatoslav Ryhel , Tom Rini , Yu Chien Peter Lin , Huan Zhou , Kongyang Liu , Padmarao Begari Subject: Re: [PATCH] riscv: spacemit: k1: probe dram size during boot phase. Message-ID: <20250108111105-GYA3276837@gentoo> References: <20250108-get-dram-size-v1-1-4bae32ecf756@per1cycle.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250108-get-dram-size-v1-1-4bae32ecf756@per1cycle.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Huan: On 16:49 Wed 08 Jan , Huan Zhou wrote: > > .. > --- remove above "---"? otherwise following commit message will be dropped during patch application.. > This patch introduce improvement for get dram size on bananapi BPI-F3, > retrieving the dram size dynamically. > Have tested on bananapi BPIF3 4G and jupiter 8G. > > Signed-off-by: Huan Zhou > --- > arch/riscv/cpu/k1/dram.c | 40 ++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 38 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/cpu/k1/dram.c b/arch/riscv/cpu/k1/dram.c > index c477c15cbfb19f0e3a0ee72985b602f5bda352d7..095217f2a4c053f7477d62c0776bcb51e623db47 100644 > --- a/arch/riscv/cpu/k1/dram.c > +++ b/arch/riscv/cpu/k1/dram.c > @@ -4,17 +4,53 @@ > */ > > #include > +#include > #include > +#include > #include > #include > > +#define DDR_BASE 0xC0000000 > DECLARE_GLOBAL_DATA_PTR; > > +static inline u32 map_format_size(u32 val) > +{ > + u32 tmp; > + > + if (val & 0x1 == 0) please add brackets explicitly, something like if ((val & 0x1) == 0) > + return 0; > + > + tmp = bitfield_extract(val, 16, 5); > + switch (tmp) { > + case 0xd: > + return 512; > + case 0xe: > + return 1024; > + case 0xf: > + return 2048; > + case 0x10: > + return 4096; > + case 0x11: > + return 8192; > + default: > + pr_info("Invalid DRAM density %x\n", val); > + return 0; > + } > +} > + > +u32 ddr_get_density(void) > +{ > + u32 cs0_size = map_format_size(readl((void *)DDR_BASE + 0x200)); > + u32 cs1_size = map_format_size(readl((void *)DDR_BASE + 0x208)); > + u32 ddr_size = cs0_size + cs1_size; > + > + return ddr_size; > +} > + > int dram_init(void) > { > gd->ram_base = CFG_SYS_SDRAM_BASE; > - /* TODO get ram size from ddr controller */ > - gd->ram_size = SZ_4G; > + gd->ram_size = (u64)ddr_get_density() * SZ_1M; while using cast, why not define ddr_get_density() return as same type? also it's more reasonable to use phys_size_t as I checked gd_t > return 0; > } > > > --- > base-commit: 19fc0b7f7d907119a13e9c207991899f0817f8fc > change-id: 20250108-get-dram-size-65cf59a15201 > > Best regards, > -- > Huan Zhou > -- Yixun Lan (dlan) Gentoo Linux Developer GPG Key ID AABEFD55