Re: [LTP] [PATCH v2 2/6] tst_run_shell: Make the tst_test struct static

[Petr Vorel <pvorel@suse.cz>]

Hi Cyril,

> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> Suggested-by: Petr Vorel <pvorel@suse.cz>
> ---
>  testcases/lib/tst_run_shell.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/testcases/lib/tst_run_shell.c b/testcases/lib/tst_run_shell.c
> index 0b86233dd..54463c04d 100644
> --- a/testcases/lib/tst_run_shell.c
> +++ b/testcases/lib/tst_run_shell.c
> @@ -26,7 +26,7 @@ static void run_shell_tcnt(unsigned int n)
>  	tst_run_script(shell_filename, params);
>  }

> -struct tst_test test = {
> +static struct tst_test test = {

Thanks!

Could you please before merge also fix formatting error?

tst_run_shell.c:144: ERROR: "(foo*)" should be "(foo *)"

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr


>  	.runs_script = 1,
>  };

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp