From: Ilya Leoshkevich <iii@linux.ibm.com>
To: "Warner Losh" <imp@bsdimp.com>,
"Riku Voipio" <riku.voipio@iki.fi>,
"Laurent Vivier" <laurent@vivier.eu>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: "Kyle Evans" <kevans@freebsd.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org, "Ilya Leoshkevich" <iii@linux.ibm.com>
Subject: [PATCH v4 1/9] qapi: Make qapi_bool_parse() gracefully handle NULL value
Date: Wed, 8 Jan 2025 21:04:56 +0100 [thread overview]
Message-ID: <20250108202625.149869-2-iii@linux.ibm.com> (raw)
In-Reply-To: <20250108202625.149869-1-iii@linux.ibm.com>
Use g_strcmp0(), so that NULL is considered an invalid parameter value.
Suggested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
qapi/qapi-util.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/qapi/qapi-util.c b/qapi/qapi-util.c
index 65a7d184372..c6ae829f904 100644
--- a/qapi/qapi-util.c
+++ b/qapi/qapi-util.c
@@ -86,17 +86,17 @@ int qapi_enum_parse(const QEnumLookup *lookup, const char *buf,
bool qapi_bool_parse(const char *name, const char *value, bool *obj, Error **errp)
{
- if (g_str_equal(value, "on") ||
- g_str_equal(value, "yes") ||
- g_str_equal(value, "true") ||
- g_str_equal(value, "y")) {
+ if (!g_strcmp0(value, "on") ||
+ !g_strcmp0(value, "yes") ||
+ !g_strcmp0(value, "true") ||
+ !g_strcmp0(value, "y")) {
*obj = true;
return true;
}
- if (g_str_equal(value, "off") ||
- g_str_equal(value, "no") ||
- g_str_equal(value, "false") ||
- g_str_equal(value, "n")) {
+ if (!g_strcmp0(value, "off") ||
+ !g_strcmp0(value, "no") ||
+ !g_strcmp0(value, "false") ||
+ !g_strcmp0(value, "n")) {
*obj = false;
return true;
}
--
2.47.1
next prev parent reply other threads:[~2025-01-08 20:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 20:04 [PATCH v4 0/9] gdbstub: Allow late attachment Ilya Leoshkevich
2025-01-08 20:04 ` Ilya Leoshkevich [this message]
2025-01-10 11:33 ` [PATCH v4 1/9] qapi: Make qapi_bool_parse() gracefully handle NULL value Daniel P. Berrangé
2025-01-10 13:03 ` Ilya Leoshkevich
2025-01-10 13:32 ` Daniel P. Berrangé
2025-01-08 20:04 ` [PATCH v4 2/9] gdbstub: Allow the %d placeholder in the socket path Ilya Leoshkevich
2025-01-08 20:04 ` [PATCH v4 3/9] gdbstub: Try unlinking the unix socket before binding Ilya Leoshkevich
2025-01-08 20:04 ` [PATCH v4 4/9] user: Introduce user/signal.h Ilya Leoshkevich
2025-01-08 20:05 ` [PATCH v4 5/9] user: Introduce host_interrupt_signal Ilya Leoshkevich
2025-01-08 20:05 ` [PATCH v4 6/9] osdep: Introduce qemu_kill_thread() Ilya Leoshkevich
2025-01-08 20:05 ` [PATCH v4 7/9] gdbstub: Allow late attachment Ilya Leoshkevich
2025-01-08 20:05 ` [PATCH v4 8/9] docs/user: Document the %d placeholder and suspend=n QEMU_GDB features Ilya Leoshkevich
2025-01-08 20:05 ` [PATCH v4 9/9] tests/tcg: Add late gdbstub attach test Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250108202625.149869-2-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=alex.bennee@linaro.org \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.