All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Hsin-chen Chuang <chharry@chromium.org>
Cc: linux-bluetooth@vger.kernel.org, luiz.dentz@gmail.com,
	chromeos-bluetooth-upstreaming@chromium.org,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Marcel Holtmann <marcel@holtmann.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Allow reset via sysfs
Date: Wed, 8 Jan 2025 13:33:59 +0100	[thread overview]
Message-ID: <2025010829-used-halves-7342@gregkh> (raw)
In-Reply-To: <20250103112019.1.I8342291b757b20cd4cdbbfe658dc58ed5df46565@changeid>

On Fri, Jan 03, 2025 at 11:20:20AM +0800, Hsin-chen Chuang wrote:
> Allow sysfs to trigger reset via the cmd_timeout function in hci device.
> This is required to recover devices that are not responsive from
> userspace.
> 
> Also remove the cmd timeout count in btusb since we only ever allow one
> command in flight at a time. We should always reset after a single
> command times out.
> 
> Signed-off-by: Hsin-chen Chuang <chharry@chromium.org>
> ---
> This commit has been tested on a Chromebook by running
> `echo 1 > /sys/class/bluetooth/hci0/reset`

You forgot the required Documentation/ABI/ update for your new sysfs
file :(

thanks,

greg k-h

  parent reply	other threads:[~2025-01-08 12:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-03  3:20 [PATCH] Bluetooth: Allow reset via sysfs Hsin-chen Chuang
2025-01-03  3:45 ` bluez.test.bot
2025-01-06 16:29 ` [PATCH] " Luiz Augusto von Dentz
2025-01-07  7:21   ` Hsin-chen Chuang
2025-01-07 16:51     ` Luiz Augusto von Dentz
2025-01-08 12:33 ` Greg KH [this message]
2025-01-08 15:06   ` Luiz Augusto von Dentz
2025-01-08 15:10     ` Greg KH
2025-01-08 15:33       ` Luiz Augusto von Dentz
2025-01-08 16:13         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025010829-used-halves-7342@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=chharry@chromium.org \
    --cc=chromeos-bluetooth-upstreaming@chromium.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.