From: Jakub Kicinski <kuba@kernel.org>
To: Potin Lai <potin.lai@quantatw.com>
Cc: Paul Fertser <fercerpav@gmail.com>,
Samuel Mendoza-Jonas <sam@mendozajonas.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Ivan Mikhaylov <fr0st61te@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] net/ncsi: fix locking in Get MAC Address handling
Date: Thu, 9 Jan 2025 08:33:11 -0800 [thread overview]
Message-ID: <20250109083311.20f5f802@kernel.org> (raw)
In-Reply-To: <20250109145054.30925-1-fercerpav@gmail.com>
On Thu, 9 Jan 2025 17:50:54 +0300 Paul Fertser wrote:
> Obtaining RTNL lock in a response handler is not allowed since it runs
> in an atomic softirq context. Postpone setting the MAC address by adding
> a dedicated step to the configuration FSM.
>
> Fixes: 790071347a0a ("net/ncsi: change from ndo_set_mac_address to dev_set_mac_address")
> Cc: stable@vger.kernel.org
> Cc: Potin Lai <potin.lai@quantatw.com>
Neat!
Potin, please give this a test ASAP.
next prev parent reply other threads:[~2025-01-09 16:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 19:23 [PATCH net v2] Revert "net/ncsi: change from ndo_set_mac_address to dev_set_mac_address" Jakub Kicinski
2025-01-08 20:23 ` Paul Fertser
2025-01-08 21:44 ` Jakub Kicinski
2025-01-08 21:48 ` Ivan Mikhaylov
2025-01-09 3:16 ` Jakub Kicinski
2025-01-09 14:50 ` [PATCH] net/ncsi: fix locking in Get MAC Address handling Paul Fertser
2025-01-09 16:33 ` Jakub Kicinski [this message]
[not found] ` <TYSPR04MB7868EA6003981521C1B2FDAB8E1C2@TYSPR04MB7868.apcprd04.prod.outlook.com>
2025-01-11 2:18 ` 回覆: [External] " Jakub Kicinski
2025-01-11 11:12 ` Potin Lai
2025-01-13 21:19 ` Jakub Kicinski
2025-01-14 1:56 ` Potin Lai
2025-01-14 3:04 ` Jakub Kicinski
2025-01-14 3:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250109083311.20f5f802@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fercerpav@gmail.com \
--cc=fr0st61te@gmail.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=potin.lai@quantatw.com \
--cc=sam@mendozajonas.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.