From: Jakub Kicinski <kuba@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Kory Maincent <kory.maincent@bootlin.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Donald Hunter <donald.hunter@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, Kyle Swenson <kyle.swenson@est.tech>,
Dent Project <dentproject@linuxfoundation.org>,
kernel@pengutronix.de,
Maxime Chevallier <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH net-next v2 11/15] net: pse-pd: Add support for PSE device index
Date: Thu, 9 Jan 2025 08:50:02 -0800 [thread overview]
Message-ID: <20250109085002.74b6931c@kernel.org> (raw)
In-Reply-To: <Z3_415FoqTn_sV87@pengutronix.de>
On Thu, 9 Jan 2025 17:27:03 +0100 Oleksij Rempel wrote:
> > > This index is not used in the series, I see later on you'll add power
> > > evaluation strategy but that also seems to be within a domain not
> > > device?
> > >
> > > Doesn't it make sense to move patches 11-14 to the next series?
> > > The other 11 patches seem to my untrained eye to reshuffle existing
> > > stuff, so they would make sense as a cohesive series.
> >
> > Indeed PSE index is used only as user information but there is nothing
> > correlated. You are right maybe we can add PSE index when we have something
> > usable for it.
Oh, maybe you want to do the devlink-y thing then?
Devlink identifies its devices by what I'd call "sysfs name" -
bus name and device name.
This is more meaningful to user than an artificial ID.
Downside is it won't work well if you have multiple objects
under a single struct device, or multiple struct device for
one ASIC (e.g. multiple PCIe PFs on one PCIe card)
> No user, means, it is not exposed to the user space, it is not about
> actual user space users.
Can't parse this :)
next prev parent reply other threads:[~2025-01-09 16:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 10:17 [PATCH net-next v2 00/15] Arrange PSE core and update TPS23881 driver Kory Maincent
2025-01-09 10:17 ` [PATCH net-next v2 01/15] net: pse-pd: Remove unused pse_ethtool_get_pw_limit function declaration Kory Maincent
2025-01-09 10:17 ` [PATCH net-next v2 02/15] net: pse-pd: Avoid setting max_uA in regulator constraints Kory Maincent
2025-01-09 10:17 ` [PATCH net-next v2 03/15] net: pse-pd: Add power limit check Kory Maincent
2025-01-09 10:17 ` [PATCH net-next v2 04/15] net: pse-pd: tps23881: Simplify function returns by removing redundant checks Kory Maincent
2025-01-09 10:17 ` [PATCH net-next v2 05/15] net: pse-pd: tps23881: Use helpers to calculate bit offset for a channel Kory Maincent
2025-01-09 10:18 ` [PATCH net-next v2 06/15] net: pse-pd: tps23881: Add missing configuration register after disable Kory Maincent
2025-01-09 10:18 ` [PATCH net-next v2 07/15] net: pse-pd: Use power limit at driver side instead of current limit Kory Maincent
2025-01-09 10:18 ` [PATCH net-next v2 08/15] net: pse-pd: Split ethtool_get_status into multiple callbacks Kory Maincent
2025-01-09 10:18 ` [PATCH net-next v2 09/15] net: pse-pd: Remove is_enabled callback from drivers Kory Maincent
2025-01-09 10:18 ` [PATCH net-next v2 10/15] net: pse-pd: tps23881: Add support for power limit and measurement features Kory Maincent
2025-01-09 10:18 ` [PATCH net-next v2 11/15] net: pse-pd: Add support for PSE device index Kory Maincent
2025-01-09 15:59 ` Jakub Kicinski
2025-01-09 16:09 ` Kory Maincent
2025-01-09 16:27 ` Oleksij Rempel
2025-01-09 16:49 ` Kory Maincent
2025-01-09 17:16 ` Oleksij Rempel
2025-01-09 19:51 ` Jakub Kicinski
2025-01-09 19:59 ` Mark Brown
2025-01-09 22:36 ` Kory Maincent
2025-01-09 16:50 ` Jakub Kicinski [this message]
2025-01-09 17:15 ` Oleksij Rempel
2025-01-09 10:18 ` [PATCH net-next v2 12/15] net: ethtool: Add support for new PSE device index description Kory Maincent
2025-01-09 10:18 ` [PATCH net-next v2 13/15] regulator: core: Resolve supply using of_node from regulator_config Kory Maincent
2025-01-09 10:18 ` [PATCH net-next v2 14/15] net: pse-pd: Fix missing PI of_node description Kory Maincent
2025-01-09 10:18 ` [PATCH net-next v2 15/15] net: pse-pd: Clean ethtool header of PSE structures Kory Maincent
2025-01-09 18:50 ` (subset) [PATCH net-next v2 00/15] Arrange PSE core and update TPS23881 driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250109085002.74b6931c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dentproject@linuxfoundation.org \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel@pengutronix.de \
--cc=kory.maincent@bootlin.com \
--cc=kyle.swenson@est.tech \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.