All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] rt_sigqueueinfo: Add negative tests for rt_sigqueueinfo
Date: Thu, 9 Jan 2025 10:45:23 +0100	[thread overview]
Message-ID: <20250109094523.GB184406@pevik> (raw)
In-Reply-To: <Zuk6k_8ryjwZqpO9@yuki.lan>

Hi Ma Xinjian,

Gently ping.

Kind regards,
Petr

> > +static siginfo_t siginfo_einval;
> > +static siginfo_t siginfo_eperm;
> > +static siginfo_t siginfo_esrch;

> Ideally these should be allocated as guarded buffers:

> https://linux-test-project.readthedocs.io/en/latest/developers/api_c_tests.html#guarded-buffers

> You can have a look at signalfd02.c and the .bufs in the tst_test
> structure initialization.

...
> > +static void child_do(struct test_case_t *tc)
> > +{
> > +	struct sigaction sa;
> > +
> > +	sa.sa_handler = sig_handler;
> > +	SAFE_SIGEMPTYSET(&sa.sa_mask);
> > +	if (tc->sig > 0)
> > +		SAFE_SIGACTION(tc->sig, &sa, NULL);
> > +	else
> > +		SAFE_SIGACTION(SIGUSR1, &sa, NULL);
> > +
> > +	TST_CHECKPOINT_WAKE(0);
> > +	TST_CHECKPOINT_WAIT(1);

> The child will never get any signal so all that needs to be done here is
> to do TST_CHECKPOINT_WAIT() so that the child exists while the parent
> runs.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2025-01-09  9:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22  6:03 [LTP] [PATCH] rt_sigqueueinfo: Add negative tests for rt_sigqueueinfo Ma Xinjian via ltp
2024-09-17  8:15 ` Cyril Hrubis
2025-01-09  9:45   ` Petr Vorel [this message]
2025-01-09 10:15     ` [LTP] 回复: " Xinjian Ma (Fujitsu) via ltp
2025-01-09 15:02       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250109094523.GB184406@pevik \
    --to=pvorel@suse.cz \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.