From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Damien Le Moal <dlemoal@kernel.org>,
Ming Lei <ming.lei@redhat.com>,
Nilay Shroff <nilay@linux.ibm.com>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
nbd@other.debian.org, linux-scsi@vger.kernel.org,
usb-storage@lists.one-eyed-alien.net,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH 05/11] block: add a store_limit operations for sysfs entries
Date: Fri, 10 Jan 2025 10:56:01 +0100 [thread overview]
Message-ID: <20250110095601.GA11121@lst.de> (raw)
In-Reply-To: <68cd5371-f4ca-44c0-8ac7-c734da04f877@oracle.com>
On Fri, Jan 10, 2025 at 09:51:18AM +0000, John Garry wrote:
> ok, and that just comes down to the behavior of queue_var_store(), which
> mimics sysfs_ops.store
>
> I will note that queue_var_store and queue_var_store64 differ in behaviour
> here :(
>
>> ->store_limits uses
>> the simpler and harder to get wrong convention of returning 0 on
>> success.
>>
>
> understood, so any reason why not to change the rest (apart from being
> busy)?
Not real urge. The idea here was to get it right for the new one.
Changing the existing would be a lot of churn for a relatively small
improvement. For me that's only worth it when touching the area anyway.
Which might or might not happen when trying to remove the sysfs_lock
around ->store.
next prev parent reply other threads:[~2025-01-10 9:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 5:47 fix queue freeze and limit locking order v4 Christoph Hellwig
2025-01-10 5:47 ` [PATCH 01/11] block: fix docs for freezing of queue limits updates Christoph Hellwig
2025-01-10 8:43 ` John Garry
2025-01-10 5:47 ` [PATCH 02/11] block: add a queue_limits_commit_update_frozen helper Christoph Hellwig
2025-01-10 5:47 ` [PATCH 03/11] block: check BLK_FEAT_POLL under q_usage_count Christoph Hellwig
2025-01-10 5:47 ` [PATCH 04/11] block: don't update BLK_FEAT_POLL in __blk_mq_update_nr_hw_queues Christoph Hellwig
2025-01-10 5:47 ` [PATCH 05/11] block: add a store_limit operations for sysfs entries Christoph Hellwig
2025-01-10 9:15 ` John Garry
2025-01-10 9:18 ` Christoph Hellwig
2025-01-10 9:51 ` John Garry
2025-01-10 9:56 ` Christoph Hellwig [this message]
2025-01-10 9:56 ` John Garry
2025-01-10 9:57 ` Damien Le Moal
2025-01-10 10:01 ` Christoph Hellwig
2025-01-10 5:47 ` [PATCH 06/11] block: fix queue freeze vs limits lock order in sysfs store methods Christoph Hellwig
2025-01-10 5:47 ` [PATCH 07/11] nvme: fix queue freeze vs limits lock order Christoph Hellwig
2025-01-10 5:47 ` [PATCH 08/11] nbd: " Christoph Hellwig
2025-01-10 5:47 ` [PATCH 09/11] usb-storage: " Christoph Hellwig
2025-01-10 5:47 ` [PATCH 10/11] loop: refactor queue limits updates Christoph Hellwig
2025-01-10 5:47 ` [PATCH 11/11] loop: fix queue freeze vs limits lock order Christoph Hellwig
2025-01-10 14:32 ` fix queue freeze and limit locking order v4 Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2025-01-09 5:57 fix queue freeze and limit locking order v3 Christoph Hellwig
2025-01-09 5:57 ` [PATCH 05/11] block: add a store_limit operations for sysfs entries Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250110095601.GA11121@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=johannes.thumshirn@wdc.com \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=nbd@other.debian.org \
--cc=nilay@linux.ibm.com \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.