From: Alecs King <alecsk@gmail.com>
To: git@vger.kernel.org
Cc: Arti Zirk <arti.zirk@gmail.com>
Subject: [PATCH] instaweb: fix ip binding for the python http.server
Date: Fri, 10 Jan 2025 18:13:46 +0800 [thread overview]
Message-ID: <20250110101346.30416-1-alecsk@gmail.com> (raw)
`git instaweb -d python` should bind the server to 0.0.0.0
`git instaweb -d python -l` should bind the server to 127.0.0.1
Signed-off-by: Alecs King <alecsk@gmail.com>
---
git-instaweb.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-instaweb.sh b/git-instaweb.sh
index 5ad50160bb..7b44f70789 100755
--- a/git-instaweb.sh
+++ b/git-instaweb.sh
@@ -694,9 +694,9 @@ class GitWebRequestHandler(CGIHTTPRequestHandler):
return result
-bind = "127.0.0.1"
+bind = "0.0.0.0"
if "$local" == "true":
- bind = "0.0.0.0"
+ bind = "127.0.0.1"
# Set our http root directory
# This is a work around for a missing directory argument in older Python versions
--
2.47.1
next reply other threads:[~2025-01-10 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 10:13 Alecs King [this message]
2025-01-10 23:32 ` [PATCH] instaweb: fix ip binding for the python http.server Junio C Hamano
2025-01-15 9:24 ` Arti Zirk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250110101346.30416-1-alecsk@gmail.com \
--to=alecsk@gmail.com \
--cc=arti.zirk@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.