All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alejandro Vallejo <alejandro.vallejo@cloud.com>
To: xen-devel@lists.xenproject.org
Cc: "Alejandro Vallejo" <alejandro.vallejo@cloud.com>,
	"Jan Beulich" <jbeulich@suse.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH v3 05/12] x86/hvm: Map/unmap xsave area in hvmemul_{get,put}_fpu()
Date: Fri, 10 Jan 2025 13:28:16 +0000	[thread overview]
Message-ID: <20250110132823.24348-6-alejandro.vallejo@cloud.com> (raw)
In-Reply-To: <20250110132823.24348-1-alejandro.vallejo@cloud.com>

No functional change.

Signed-off-by: Alejandro Vallejo <alejandro.vallejo@cloud.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
v2->v3:
  * style: Capitalized first letter of the fastpath comment
  * Added A-by

v1->v2:
  * Added comments highlighting fastpath for current
---
 xen/arch/x86/hvm/emulate.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c
index a1935a174830..d5011612aff0 100644
--- a/xen/arch/x86/hvm/emulate.c
+++ b/xen/arch/x86/hvm/emulate.c
@@ -2371,7 +2371,9 @@ static int cf_check hvmemul_get_fpu(
         alternative_vcall(hvm_funcs.fpu_dirty_intercept);
     else if ( type == X86EMUL_FPU_fpu )
     {
-        const fpusse_t *fpu_ctxt = &curr->arch.xsave_area->fpu_sse;
+        /* Has a fastpath for `current`, so there's no actual map */
+        const struct xsave_struct *xsave_area = VCPU_MAP_XSAVE_AREA(curr);
+        const fpusse_t *fpu_ctxt = &xsave_area->fpu_sse;
 
         /*
          * Latch current register state so that we can back out changes
@@ -2397,6 +2399,8 @@ static int cf_check hvmemul_get_fpu(
             else
                 ASSERT(fcw == fpu_ctxt->fcw);
         }
+
+        VCPU_UNMAP_XSAVE_AREA(curr, xsave_area);
     }
 
     return X86EMUL_OKAY;
@@ -2411,7 +2415,9 @@ static void cf_check hvmemul_put_fpu(
 
     if ( aux )
     {
-        fpusse_t *fpu_ctxt = &curr->arch.xsave_area->fpu_sse;
+        /* Has a fastpath for `current`, so there's no actual map */
+        struct xsave_struct *xsave_area = VCPU_MAP_XSAVE_AREA(curr);
+        fpusse_t *fpu_ctxt = &xsave_area->fpu_sse;
         bool dval = aux->dval;
         int mode = hvm_guest_x86_mode(curr);
 
@@ -2467,6 +2473,8 @@ static void cf_check hvmemul_put_fpu(
 
         fpu_ctxt->fop = aux->op;
 
+        VCPU_UNMAP_XSAVE_AREA(curr, xsave_area);
+
         /* Re-use backout code below. */
         backout = X86EMUL_FPU_fpu;
     }
-- 
2.47.1



  parent reply	other threads:[~2025-01-10 13:29 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10 13:28 [PATCH v3 00/12] x86: Address Space Isolation FPU preparations Alejandro Vallejo
2025-01-10 13:28 ` [PATCH v3 01/12] x86/xstate: Create map/unmap primitives for xsave areas Alejandro Vallejo
2025-01-27 10:44   ` Jan Beulich
2025-01-27 15:33     ` Alejandro Vallejo
2025-01-10 13:28 ` [PATCH v3 02/12] x86/hvm: Map/unmap xsave area in hvm_save_cpu_ctxt() Alejandro Vallejo
2025-01-10 13:28 ` [PATCH v3 03/12] x86/fpu: Map/umap xsave area in vcpu_{reset,setup}_fpu() Alejandro Vallejo
2025-01-10 13:28 ` [PATCH v3 04/12] x86/xstate: Map/unmap xsave area in xstate_set_init() and handle_setbv() Alejandro Vallejo
2025-01-10 13:28 ` Alejandro Vallejo [this message]
2025-01-10 13:28 ` [PATCH v3 06/12] x86/domctl: Map/unmap xsave area in arch_get_info_guest() Alejandro Vallejo
2025-01-10 13:28 ` [PATCH v3 07/12] x86/xstate: Map/unmap xsave area in {compress,expand}_xsave_states() Alejandro Vallejo
2025-01-27 10:46   ` Jan Beulich
2025-01-10 13:28 ` [PATCH v3 08/12] x86/emulator: Refactor FXSAVE_AREA to use wrappers Alejandro Vallejo
2025-01-27 10:52   ` Jan Beulich
2025-01-27 15:42     ` Alejandro Vallejo
2025-01-27 16:59       ` Jan Beulich
2025-03-05 15:29   ` Jan Beulich
2025-03-05 16:16     ` Alejandro Vallejo
2025-03-05 16:17       ` Jan Beulich
2025-01-10 13:28 ` [PATCH v3 09/12] x86/mpx: Map/unmap xsave area in in read_bndcfgu() Alejandro Vallejo
2025-01-27 10:57   ` Jan Beulich
2025-01-27 14:14     ` Alejandro Vallejo
2025-01-10 13:28 ` [PATCH v3 10/12] x86/fpu: Pass explicit xsave areas to fpu_(f)xsave() Alejandro Vallejo
2025-01-27 11:01   ` Jan Beulich
2025-01-27 15:43     ` Alejandro Vallejo
2025-01-10 13:28 ` [PATCH v3 11/12] x86/fpu: Pass explicit xsave areas to fpu_(f)xrstor() Alejandro Vallejo
2025-01-27 11:05   ` Jan Beulich
2025-01-27 15:48     ` Alejandro Vallejo
2025-01-27 17:01       ` Jan Beulich
2025-01-10 13:28 ` [PATCH v3 12/12] x86/xstate: Make xstate_all() and vcpu_xsave_mask() take explicit xstate Alejandro Vallejo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250110132823.24348-6-alejandro.vallejo@cloud.com \
    --to=alejandro.vallejo@cloud.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.