From: Jakub Kicinski <kuba@kernel.org>
To: Yeking@Red54.com
Cc: netdev@vger.kernel.org, Wells Lu <wellslutw@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v4] net: ethernet: sunplus: Switch to ndo_eth_ioctl
Date: Fri, 10 Jan 2025 17:57:37 -0800 [thread overview]
Message-ID: <20250110175737.7535f4e7@kernel.org> (raw)
In-Reply-To: <tencent_BDD603E969ED7B30ACFBFFBA9EA3DA3D7E09@qq.com>
On Fri, 10 Jan 2025 13:29:21 +0000 Yeking@Red54.com wrote:
> Fixes: fd3040b9394c ("net: ethernet: Add driver for Sunplus SP7021")
> Fixes: a76053707dbf ("dev_ioctl: split out ndo_eth_ioctl")
I see your point with the ordering of the commits, please drop
the second Fixes tag, then :) I'd slightly modify your commit
message to make this clearer:
The device ioctl handler no longer calls ndo_do_ioctl, but calls
ndo_eth_ioctl to handle mii ioctls. However, even though sunplus
was introduced after commit a76053707dbf ("dev_ioctl: split out
ndo_eth_ioctl"), it still tried to use ndo_do_ioctl.
Switch to ndo_eth_ioctl. (found by code inspection)
Fixes: fd3040b9394c ("net: ethernet: Add driver for Sunplus SP7021")
--
pw-bot: cr
next prev parent reply other threads:[~2025-01-11 1:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 13:29 [PATCH net v4] net: ethernet: sunplus: Switch to ndo_eth_ioctl Yeking
2025-01-11 1:57 ` Jakub Kicinski [this message]
2025-01-13 9:41 ` [PATCH net v5] " Yeking
2025-01-15 2:11 ` Jakub Kicinski
2025-01-15 2:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250110175737.7535f4e7@kernel.org \
--to=kuba@kernel.org \
--cc=Yeking@Red54.com \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wellslutw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.