From: Jakub Kicinski <kuba@kernel.org>
To: Yeking@Red54.com
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Prarit Bhargava <prarit@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [net PATCH] net: appletalk: Drop aarp_send_probe_phase1()
Date: Fri, 10 Jan 2025 18:24:35 -0800 [thread overview]
Message-ID: <20250110182435.6b811abe@kernel.org> (raw)
In-Reply-To: <tencent_50197BA0ACE5FECA9F15DB877ED002416809@qq.com>
On Thu, 9 Jan 2025 12:27:51 +0000 Yeking@Red54.com wrote:
> Due to the ltpc, cops, and ipddp drivers have been deleted,
> aarp_send_probe_phase1() no longer works. (found by code inspection)
Could you explain more? What is your thought process?
> Fixes: 1dab47139e61 ("appletalk: remove ipddp driver")
> Fixes: 00f3696f7555 ("net: appletalk: remove cops support")
> Fixes: 03dcb90dbf62 ("net: appletalk: remove Apple/Farallon LocalTalk PC support")
> Fixes: dbecb011eb78 ("appletalk: use ndo_siocdevprivate")
Dead code is not a bug, you can mention the relevant commits
in the commit message, but no Fixes tag are appropriate here.
--
pw-bot: cr
next prev parent reply other threads:[~2025-01-11 2:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 12:27 [net PATCH] net: appletalk: Drop aarp_send_probe_phase1() Yeking
2025-01-11 2:24 ` Jakub Kicinski [this message]
2025-01-13 9:44 ` [PATCH net v2] " Yeking
2025-01-15 22:06 ` Jakub Kicinski
2025-01-17 1:41 ` [PATCH net-next v3] " Yeking
2025-01-20 10:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250110182435.6b811abe@kernel.org \
--to=kuba@kernel.org \
--cc=Yeking@Red54.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=prarit@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.