From: Greg KH <gregkh@linuxfoundation.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Alice Ryhl <aliceryhl@google.com>,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
ojeda@kernel.org, sfr@canb.auug.org.au
Subject: Re: [PATCH] miscdevice: rust: use build_error! macro instead of function
Date: Fri, 10 Jan 2025 13:23:43 +0100 [thread overview]
Message-ID: <2025011022-nemesis-scorn-6772@gregkh> (raw)
In-Reply-To: <CANiq72=N9RMKRBtEuf8qr1oaNVVtfto2S1wXLPRxzfH5N4q=uQ@mail.gmail.com>
On Fri, Jan 10, 2025 at 11:38:10AM +0100, Miguel Ojeda wrote:
> On Fri, Jan 10, 2025 at 11:15 AM Alice Ryhl <aliceryhl@google.com> wrote:
> >
> > The function called build_error is an implementation detail of the macro
> > of the same name. Thus, update miscdevice to use the macro rather than
> > the function. See [1] for more information on this.
> >
> > This use the macro with the kernel:: prefix as it has not yet been added
> > to the prelude.
>
> Typo: "These"
>
> Acked-by: Miguel Ojeda <ojeda@kernel.org>
And I'll add a Reported-by: line when I apply this in a few minutes,
thanks!
greg k-h
next prev parent reply other threads:[~2025-01-10 12:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 5:28 linux-next: build failure after merge of the rust tree Stephen Rothwell
2025-01-10 9:28 ` Alice Ryhl
2025-01-10 9:34 ` Greg Kroah-Hartman
2025-01-10 9:41 ` Alice Ryhl
2025-01-10 10:07 ` Alice Ryhl
2025-01-10 10:14 ` [PATCH] miscdevice: rust: use build_error! macro instead of function Alice Ryhl
2025-01-10 10:38 ` Miguel Ojeda
2025-01-10 12:23 ` Greg KH [this message]
2025-01-10 12:32 ` Alice Ryhl
2025-01-10 10:08 ` linux-next: build failure after merge of the rust tree Miguel Ojeda
2025-01-10 10:16 ` Miguel Ojeda
2025-01-10 10:38 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025011022-nemesis-scorn-6772@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=aliceryhl@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.