From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: [xilinx-xlnx:lkp_test 64/504] drivers/uio/uio_dmabuf.c:163:5-13: ERROR: invalid reference to the index variable of the iterator on line 158
Date: Sat, 11 Jan 2025 19:51:26 +0800 [thread overview]
Message-ID: <202501111908.L8JbKBdE-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: git@amd.com
TO: Hyun Kwon <hyun.kwon@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
tree: https://github.com/Xilinx/linux-xlnx lkp_test
head: 9ac6b4acf9144465ac1408d4d799635dec0223a0
commit: 172f9f2dc4ebdce5fcf324e2718316b84c040621 [64/504] uio: Add dma-buf import ioctls
:::::: branch date: 27 hours ago
:::::: commit date: 4 days ago
config: microblaze-randconfig-r054-20250111 (https://download.01.org/0day-ci/archive/20250111/202501111908.L8JbKBdE-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 14.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202501111908.L8JbKBdE-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/uio/uio_dmabuf.c:163:5-13: ERROR: invalid reference to the index variable of the iterator on line 158
vim +163 drivers/uio/uio_dmabuf.c
172f9f2dc4ebdc Hyun Kwon 2019-03-04 143
172f9f2dc4ebdc Hyun Kwon 2019-03-04 144 long uio_dmabuf_unmap(struct uio_device *dev, struct list_head *dbufs,
172f9f2dc4ebdc Hyun Kwon 2019-03-04 145 struct mutex *dbufs_lock, void __user *user_args)
172f9f2dc4ebdc Hyun Kwon 2019-03-04 146
172f9f2dc4ebdc Hyun Kwon 2019-03-04 147 {
172f9f2dc4ebdc Hyun Kwon 2019-03-04 148 struct uio_dmabuf_args args;
172f9f2dc4ebdc Hyun Kwon 2019-03-04 149 struct uio_dmabuf_mem *dbuf_mem;
172f9f2dc4ebdc Hyun Kwon 2019-03-04 150 long ret;
172f9f2dc4ebdc Hyun Kwon 2019-03-04 151
172f9f2dc4ebdc Hyun Kwon 2019-03-04 152 if (copy_from_user(&args, user_args, sizeof(args))) {
172f9f2dc4ebdc Hyun Kwon 2019-03-04 153 ret = -EFAULT;
172f9f2dc4ebdc Hyun Kwon 2019-03-04 154 goto err;
172f9f2dc4ebdc Hyun Kwon 2019-03-04 155 }
172f9f2dc4ebdc Hyun Kwon 2019-03-04 156
172f9f2dc4ebdc Hyun Kwon 2019-03-04 157 mutex_lock(dbufs_lock);
172f9f2dc4ebdc Hyun Kwon 2019-03-04 @158 list_for_each_entry(dbuf_mem, dbufs, list) {
172f9f2dc4ebdc Hyun Kwon 2019-03-04 159 if (dbuf_mem->dbuf_fd == args.dbuf_fd)
172f9f2dc4ebdc Hyun Kwon 2019-03-04 160 break;
172f9f2dc4ebdc Hyun Kwon 2019-03-04 161 }
172f9f2dc4ebdc Hyun Kwon 2019-03-04 162
172f9f2dc4ebdc Hyun Kwon 2019-03-04 @163 if (dbuf_mem->dbuf_fd != args.dbuf_fd) {
172f9f2dc4ebdc Hyun Kwon 2019-03-04 164 dev_err(dev->dev.parent, "failed to find the dmabuf (%d)\n",
172f9f2dc4ebdc Hyun Kwon 2019-03-04 165 args.dbuf_fd);
172f9f2dc4ebdc Hyun Kwon 2019-03-04 166 ret = -EINVAL;
172f9f2dc4ebdc Hyun Kwon 2019-03-04 167 goto err_unlock;
172f9f2dc4ebdc Hyun Kwon 2019-03-04 168 }
172f9f2dc4ebdc Hyun Kwon 2019-03-04 169 list_del(&dbuf_mem->list);
172f9f2dc4ebdc Hyun Kwon 2019-03-04 170 mutex_unlock(dbufs_lock);
172f9f2dc4ebdc Hyun Kwon 2019-03-04 171
172f9f2dc4ebdc Hyun Kwon 2019-03-04 172 dma_buf_unmap_attachment(dbuf_mem->dbuf_attach, dbuf_mem->sgt,
172f9f2dc4ebdc Hyun Kwon 2019-03-04 173 dbuf_mem->dir);
172f9f2dc4ebdc Hyun Kwon 2019-03-04 174 dma_buf_detach(dbuf_mem->dbuf, dbuf_mem->dbuf_attach);
172f9f2dc4ebdc Hyun Kwon 2019-03-04 175 dma_buf_put(dbuf_mem->dbuf);
172f9f2dc4ebdc Hyun Kwon 2019-03-04 176 kfree(dbuf_mem);
172f9f2dc4ebdc Hyun Kwon 2019-03-04 177
172f9f2dc4ebdc Hyun Kwon 2019-03-04 178 memset(&args, 0x0, sizeof(args));
172f9f2dc4ebdc Hyun Kwon 2019-03-04 179
172f9f2dc4ebdc Hyun Kwon 2019-03-04 180 if (copy_to_user(user_args, &args, sizeof(args))) {
172f9f2dc4ebdc Hyun Kwon 2019-03-04 181 ret = -EFAULT;
172f9f2dc4ebdc Hyun Kwon 2019-03-04 182 goto err;
172f9f2dc4ebdc Hyun Kwon 2019-03-04 183 }
172f9f2dc4ebdc Hyun Kwon 2019-03-04 184
172f9f2dc4ebdc Hyun Kwon 2019-03-04 185 return 0;
172f9f2dc4ebdc Hyun Kwon 2019-03-04 186
172f9f2dc4ebdc Hyun Kwon 2019-03-04 187 err_unlock:
172f9f2dc4ebdc Hyun Kwon 2019-03-04 188 mutex_unlock(dbufs_lock);
172f9f2dc4ebdc Hyun Kwon 2019-03-04 189 err:
172f9f2dc4ebdc Hyun Kwon 2019-03-04 190 return ret;
172f9f2dc4ebdc Hyun Kwon 2019-03-04 191 }
172f9f2dc4ebdc Hyun Kwon 2019-03-04 192
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2025-01-11 11:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202501111908.L8JbKBdE-lkp@intel.com \
--to=lkp@intel.com \
--cc=julia.lawall@inria.fr \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.