From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
<andrew+netdev@lunn.ch>, <netdev@vger.kernel.org>,
<anton.nadezhdin@intel.com>, <przemyslaw.kitszel@intel.com>,
<milena.olech@intel.com>, <arkadiusz.kubalewski@intel.com>,
<richardcochran@gmail.com>,
"Karol Kolacinski" <karol.kolacinski@intel.com>,
Rinitha S <sx.rinitha@intel.com>
Subject: Re: [PATCH net-next 08/13] ice: use rd32_poll_timeout_atomic in ice_read_phy_tstamp_ll_e810
Date: Mon, 13 Jan 2025 10:33:06 -0800 [thread overview]
Message-ID: <20250113103306.5b4f8f86@kernel.org> (raw)
In-Reply-To: <a0b535bd-3569-4d36-9752-ec8dcdc23aaf@intel.com>
On Mon, 13 Jan 2025 10:18:05 -0800 Jacob Keller wrote:
> > Ack, and short hands make sense. But both rd32_poll_timeout_atomic and
> > the exiting rd32_poll_timeout have a single user.
>
> The intention with introducing these is to help make it easier for other
> developers to use poll_timeout and friends throughout the driver.
> There's only one user now, but my intention had been that we'd see more
> as it becomes more known and is easier to use.
IMHO the ease of use gain is equal to the loss of generality (driver
local flavor of a common function will make contributing outside the
driver harder).
To be clear it's not a blocker, I'm only complaining because there was
a bug in the other patch.
next prev parent reply other threads:[~2025-01-13 18:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 22:17 [PATCH net-next 00/13][pull request] Intel Wired LAN Driver Updates 2025-01-08 (ice) Tony Nguyen
2025-01-08 22:17 ` [PATCH net-next 01/13] ice: c827: move wait for FW to ice_init_hw() Tony Nguyen
2025-01-08 22:17 ` [PATCH net-next 02/13] ice: split ice_init_hw() out from ice_init_dev() Tony Nguyen
2025-01-08 22:17 ` [PATCH net-next 03/13] ice: minor: rename goto labels from err to unroll Tony Nguyen
2025-01-08 22:17 ` [PATCH net-next 04/13] ice: ice_probe: init ice_adapter after HW init Tony Nguyen
2025-01-08 22:17 ` [PATCH net-next 05/13] ice: add recipe priority check in search Tony Nguyen
2025-01-08 22:17 ` [PATCH net-next 06/13] ice: add fw and port health reporters Tony Nguyen
2025-01-08 22:17 ` [PATCH net-next 07/13] ice: use string choice helpers Tony Nguyen
2025-01-08 22:17 ` [PATCH net-next 08/13] ice: use rd32_poll_timeout_atomic in ice_read_phy_tstamp_ll_e810 Tony Nguyen
2025-01-10 2:21 ` Jakub Kicinski
2025-01-11 0:50 ` Jacob Keller
2025-01-11 1:25 ` Jakub Kicinski
2025-01-13 18:18 ` Jacob Keller
2025-01-13 18:33 ` Jakub Kicinski [this message]
2025-01-08 22:17 ` [PATCH net-next 09/13] ice: rename TS_LL_READ* macros to REG_LL_PROXY_H_* Tony Nguyen
2025-01-08 22:17 ` [PATCH net-next 10/13] ice: add lock to protect low latency interface Tony Nguyen
2025-01-08 22:17 ` [PATCH net-next 11/13] ice: check low latency PHY timer update firmware capability Tony Nguyen
2025-01-08 22:17 ` [PATCH net-next 12/13] ice: implement low latency PHY timer updates Tony Nguyen
2025-01-10 2:18 ` Jakub Kicinski
2025-01-13 18:50 ` Jacob Keller
2025-01-13 20:46 ` Michal Schmidt
2025-01-13 21:17 ` Jacob Keller
2025-01-13 21:40 ` Jacob Keller
2025-01-08 22:17 ` [PATCH net-next 13/13] ice: Add in/out PTP pin delays Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250113103306.5b4f8f86@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=anton.nadezhdin@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=karol.kolacinski@intel.com \
--cc=milena.olech@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=richardcochran@gmail.com \
--cc=sx.rinitha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.