From: Peter Zijlstra <peterz@infradead.org>
To: Borislav Petkov <bp@alien8.de>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Mike Rapoport" <rppt@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Andreas Larsson" <andreas@gaisler.com>,
"Andy Lutomirski" <luto@kernel.org>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>, "Brian Cain" <bcain@quicinc.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Christoph Hellwig" <hch@infradead.org>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Dinh Nguyen" <dinguyen@kernel.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Guo Ren" <guoren@kernel.org>, "Helge Deller" <deller@gmx.de>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
"Kent Overstreet" <kent.overstreet@linux.dev>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Matt Turner" <mattst88@gmail.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Michal Simek" <monstr@monstr.eu>,
"Oleg Nesterov" <oleg@redhat.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Richard Weinberger" <richard@nod.at>,
"Russell King" <linux@armlinux.org.uk>,
"Song Liu" <song@kernel.org>, "Stafford Horne" <shorne@gmail.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Suren Baghdasaryan" <surenb@google.com>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Uladzislau Rezki" <urezki@gmail.com>,
"Vineet Gupta" <vgupta@kernel.org>,
"Will Deacon" <will@kernel.org>,
bpf@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-mips@vger.kernel.org, linux-mm@kvack.org,
linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org,
linux-parisc@vger.kernel.or
Subject: Re: [REGRESSION] Re: [PATCH v7 8/8] x86/module: enable ROX caches for module text on 64 bit
Date: Mon, 13 Jan 2025 12:11:16 +0100 [thread overview]
Message-ID: <20250113111116.GF5388@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20250112190755.GCZ4QTC01KzoZkxel9@fat_crate.local>
On Sun, Jan 12, 2025 at 08:07:55PM +0100, Borislav Petkov wrote:
> On Sun, Jan 12, 2025 at 08:42:05PM +0200, Ville Syrjälä wrote:
> > On Wed, Oct 23, 2024 at 07:27:11PM +0300, Mike Rapoport wrote:
> > > From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
> > >
> > > Enable execmem's cache of PMD_SIZE'ed pages mapped as ROX for module
> > > text allocations on 64 bit.
> >
> > Hi,
> >
> > This breaks resume from hibernation on my Alderlake laptop.
> >
> > Fortunately this still reverts cleanly.
>
> Does that hunk in the mail here fix it?
>
> https://lore.kernel.org/all/Z4DwPkcYyZ-tDKwY@kernel.org/
There's definiltely breakage with that module_writable_address()
nonsense in alternative.c that will not be fixed by that patch.
The very simplest thing at this point is to remove:
select ARCH_HAS_EXECMEM_ROX if X86_64
and try again next cycle.
next prev parent reply other threads:[~2025-01-13 11:11 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 16:27 [PATCH v7 0/8] x86/module: use large ROX pages for text allocations Mike Rapoport
2024-10-23 16:27 ` Mike Rapoport
2024-10-23 16:27 ` Mike Rapoport
2024-10-23 16:27 ` [PATCH v7 1/8] mm: vmalloc: group declarations depending on CONFIG_MMU together Mike Rapoport
2024-10-23 16:27 ` Mike Rapoport
2024-10-23 16:27 ` Mike Rapoport
2024-10-23 16:27 ` [PATCH v7 2/8] mm: vmalloc: don't account for number of nodes for HUGE_VMAP allocations Mike Rapoport
2024-10-23 16:27 ` Mike Rapoport
2024-10-23 16:27 ` Mike Rapoport
2024-10-23 16:27 ` [PATCH v7 3/8] asm-generic: introduce text-patching.h Mike Rapoport
2024-10-23 16:27 ` Mike Rapoport
2024-10-23 16:27 ` Mike Rapoport
2024-10-23 16:27 ` [PATCH v7 4/8] module: prepare to handle ROX allocations for text Mike Rapoport
2024-10-23 16:27 ` Mike Rapoport
2024-10-23 16:27 ` Mike Rapoport
2024-10-23 16:27 ` [PATCH v7 5/8] arch: introduce set_direct_map_valid_noflush() Mike Rapoport
2024-10-23 16:27 ` Mike Rapoport
2024-10-23 16:27 ` Mike Rapoport
2024-10-23 16:27 ` [PATCH v7 6/8] x86/module: prepare module loading for ROX allocations of text Mike Rapoport
2024-10-23 16:27 ` Mike Rapoport
2024-10-23 16:27 ` Mike Rapoport
2024-11-04 23:27 ` Nathan Chancellor
2024-11-04 23:27 ` Nathan Chancellor
2024-11-04 23:27 ` Nathan Chancellor
2024-11-05 7:02 ` Mike Rapoport
2024-11-05 7:02 ` Mike Rapoport
2024-11-05 7:02 ` Mike Rapoport
2024-11-05 19:04 ` Nathan Chancellor
2024-11-05 19:04 ` Nathan Chancellor
2024-11-05 19:04 ` Nathan Chancellor
2024-10-23 16:27 ` [PATCH v7 7/8] execmem: add support for cache of large ROX pages Mike Rapoport
2024-10-23 16:27 ` Mike Rapoport
2024-10-23 16:27 ` Mike Rapoport
2025-02-27 11:13 ` Ryan Roberts
2025-02-27 11:13 ` Ryan Roberts
2025-02-27 11:13 ` Ryan Roberts
2025-02-28 13:55 ` Mike Rapoport
2025-02-28 13:55 ` Mike Rapoport
2025-02-28 13:55 ` Mike Rapoport
2024-10-23 16:27 ` [PATCH v7 8/8] x86/module: enable ROX caches for module text on 64 bit Mike Rapoport
2024-10-23 16:27 ` Mike Rapoport
2024-10-23 16:27 ` Mike Rapoport
2025-01-12 18:42 ` [REGRESSION] " Ville Syrjälä
2025-01-12 18:42 ` Ville Syrjälä
2025-01-12 19:07 ` Borislav Petkov
2025-01-13 11:11 ` Peter Zijlstra [this message]
2025-01-13 11:29 ` [PATCH] x86: Disable EXECMEM_ROX support Peter Zijlstra
2025-01-13 11:51 ` Borislav Petkov
2025-01-13 11:55 ` [tip: x86/urgent] " tip-bot2 for Peter Zijlstra
2025-01-13 15:47 ` [PATCH] " Ville Syrjälä
2025-01-13 15:45 ` [REGRESSION] Re: [PATCH v7 8/8] x86/module: enable ROX caches for module text on 64 bit Ville Syrjälä
2024-11-18 18:25 ` [PATCH v7 0/8] x86/module: use large ROX pages for text allocations Steven Rostedt
2024-11-18 18:25 ` Steven Rostedt
2024-11-18 18:25 ` Steven Rostedt
2024-11-18 18:40 ` Mike Rapoport
2024-11-18 18:40 ` Mike Rapoport
2024-11-18 18:40 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250113111116.GF5388@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=andreas@gaisler.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=bcain@quicinc.com \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=dave.hansen@linux.intel.com \
--cc=deller@gmx.de \
--cc=dinguyen@kernel.org \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=guoren@kernel.org \
--cc=hch@infradead.org \
--cc=jcmvbkbc@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=kent.overstreet@linux.dev \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux-parisc@vger.kernel.or \
--cc=linux@armlinux.org.uk \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mattst88@gmail.com \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=oleg@redhat.com \
--cc=palmer@dabbelt.com \
--cc=richard@nod.at \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=shorne@gmail.com \
--cc=song@kernel.org \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=urezki@gmail.com \
--cc=vgupta@kernel.org \
--cc=ville.syrjala@linux.intel.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.