From: Peter Zijlstra <peterz@infradead.org>
To: Maria Yu <quic_aiquny@quicinc.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, kernel@quicinc.com
Subject: Re: [PATCH] sched: Use printk_deferred_once() instead of WARN_ONCE()
Date: Mon, 13 Jan 2025 14:12:43 +0100 [thread overview]
Message-ID: <20250113131243.GA8362@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20241227-sched-use-printk_deferred_once-v1-1-5da85cb38da2@quicinc.com>
On Fri, Dec 27, 2024 at 05:27:10PM +0800, Maria Yu wrote:
> A deadlock is observed when WARN_ONCE() uses printk() inside the scheduler
> logic. printk_deferred_once() is a WARN_ONCE() similar special printk
> facility for the scheduler to avoid unnecessary deadlocks.
No, problem is with printk. Using delayed will make it so that you'll
never see the output if it dies.
Only use delayed for printk()s that are expected and non fatal.
next prev parent reply other threads:[~2025-01-13 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-27 9:27 [PATCH] sched: Use printk_deferred_once() instead of WARN_ONCE() Maria Yu
2025-01-13 13:12 ` Peter Zijlstra [this message]
2025-01-13 13:16 ` Peter Zijlstra
2025-01-14 10:01 ` Aiqun(Maria) Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250113131243.GA8362@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kernel@quicinc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=quic_aiquny@quicinc.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.