From: Al Viro <viro@zeniv.linux.org.uk>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] select: Fix unbalanced user_access_end()
Date: Mon, 13 Jan 2025 19:47:44 +0000 [thread overview]
Message-ID: <20250113194744.GZ1977892@ZenIV> (raw)
In-Reply-To: <a7139e28d767a13e667ee3c79599a8047222ef36.1736751221.git.christophe.leroy@csgroup.eu>
On Mon, Jan 13, 2025 at 09:37:24AM +0100, Christophe Leroy wrote:
> While working on implementing user access validation on powerpc
> I got the following warnings on a pmac32_defconfig build:
>
> CC fs/select.o
> fs/select.o: warning: objtool: sys_pselect6+0x1bc: redundant UACCESS disable
> fs/select.o: warning: objtool: sys_pselect6_time32+0x1bc: redundant UACCESS disable
>
> On powerpc/32s, user_read_access_begin/end() are no-ops, but the
> failure path has a user_access_end() instead of user_read_access_end()
> which means an access end without any prior access begin.
>
> Replace that user_access_end() by user_read_access_end().
ACK.
prev parent reply other threads:[~2025-01-13 19:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 8:37 [PATCH] select: Fix unbalanced user_access_end() Christophe Leroy
2025-01-13 14:39 ` Christian Brauner
2025-01-13 19:47 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250113194744.GZ1977892@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.