From: Petr Vorel <pvorel@suse.cz>
To: "Ricardo B. Marliere" <rbm@suse.com>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH] lib/tst_kconfig: Include stddef.h
Date: Tue, 14 Jan 2025 03:55:07 +0100 [thread overview]
Message-ID: <20250114025507.GA564529@pevik> (raw)
In-Reply-To: <20250113-tst_kconfig_stddef-v1-1-66c75790d127@suse.com>
Hi Ricardo,
> Currently, if a test wants to make use of tst_kconfig.h it must also
> include stddef.h due to the usage of size_t. While at it, fix a few minor
<stddef.h> or <stdlib.h>
Good catch, it should be corrected.
<stdlib.h> is used in lib/tst_test.c, thus tests have it for free,
but there are libraries, which load it as well.
> typos in comments.
FYI we usually split changes into commits (easier in case of revert),
but this is, of course, OK to keep.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Also, I wondered if we want to remove these includes in files they use
tst_kconfig.h, but probably not necessary.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-01-14 2:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 22:05 [LTP] [PATCH] lib/tst_kconfig: Include stddef.h Ricardo B. Marliere via ltp
2025-01-14 2:55 ` Petr Vorel [this message]
2025-01-14 9:52 ` Petr Vorel
2025-01-14 13:18 ` Ricardo B. Marliere via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250114025507.GA564529@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=rbm@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.