All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Thiery <heiko.thiery@gmail.com>
To: buildroot@buildroot.org
Cc: "Fiona Klute" <fiona.klute@gmx.de>,
	"Heiko Thiery" <heiko.thiery@gmail.com>,
	"Jan Kundrát" <jan.kundrat@cesnet.cz>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: [Buildroot] [PATCH v5 3/9] package/sysrepo: fix shellcheck warnings of init script
Date: Tue, 14 Jan 2025 08:29:46 +0100	[thread overview]
Message-ID: <20250114072947.284965-4-heiko.thiery@gmail.com> (raw)
In-Reply-To: <20250114072947.284965-1-heiko.thiery@gmail.com>

Remove entry from .checkpackageignore

Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
---

v4:
    - new commit that only contains sysv init shellcheck warning fixes

 .checkpackageignore                | 1 -
 package/sysrepo/S51sysrepo-plugind | 3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.checkpackageignore b/.checkpackageignore
index 0dcca5ebc7..6b6fa4689d 100644
--- a/.checkpackageignore
+++ b/.checkpackageignore
@@ -1213,7 +1213,6 @@ package/suricata/0001-configure.ac-allow-the-user-to-override-RUST_TARGET.patch
 package/suricata/S99suricata Shellcheck
 package/swupdate/swupdate.sh Shellcheck
 package/sylpheed/0001-harden-link-checker-before-accepting-click.patch lib_patch.Upstream
-package/sysrepo/S51sysrepo-plugind Shellcheck lib_sysv.Indent
 package/sysvinit/0001-Makefile-disable-stack-protector-strong.patch lib_patch.Upstream
 package/tar/0001-lib-getrandom.c-fix-build-with-uclibc-1.0.35.patch lib_patch.Upstream
 package/targetcli-fb/S50target Shellcheck lib_sysv.Variables
diff --git a/package/sysrepo/S51sysrepo-plugind b/package/sysrepo/S51sysrepo-plugind
index 60ea3ba7a9..4bee6c1705 100644
--- a/package/sysrepo/S51sysrepo-plugind
+++ b/package/sysrepo/S51sysrepo-plugind
@@ -10,6 +10,7 @@ SYSREPO_PLUGIND_ARGS=""
 
 start() {
 	printf 'Starting %s: ' "$DAEMON"
+	# shellcheck disable=SC2086 # we need the word splitting
 	start-stop-daemon -S -q -x "$EXECUTABLE" \
 		-- $SYSREPO_PLUGIND_ARGS
 	status=$?
@@ -45,7 +46,7 @@ reload() {
 }
 
 case "$1" in
-    start|stop|restart|reload)
+	start|stop|restart|reload)
 		"$1";;
 	*)
 		echo "Usage: $0 {start|stop|restart|reload}"
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2025-01-14  7:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-14  7:29 [Buildroot] [PATCH v5 0/9] netopeer2 package update Heiko Thiery
2025-01-14  7:29 ` [Buildroot] [PATCH v5 1/9] package/libyang: bump to version 3.7.8 Heiko Thiery
2025-01-14  7:29 ` [Buildroot] [PATCH v5 2/9] package/libnetconf2: bump version to 3.5.5 Heiko Thiery
2025-02-03 22:41   ` Thomas Petazzoni via buildroot
2025-02-05  6:49     ` Heiko Thiery
2025-02-05  8:11       ` Thomas Petazzoni via buildroot
2025-01-14  7:29 ` Heiko Thiery [this message]
2025-02-03 22:42   ` [Buildroot] [PATCH v5 3/9] package/sysrepo: fix shellcheck warnings of init script Thomas Petazzoni via buildroot
2025-01-14  7:29 ` [Buildroot] [PATCH v5 4/9] package/sysrepo: bump version to 3.3.10 Heiko Thiery
2025-01-14  7:29 ` [Buildroot] [PATCH v5 5/9] package/netopeer2: fix shellcheck warnings Heiko Thiery
2025-02-03 22:42   ` Thomas Petazzoni via buildroot
2025-01-14  7:29 ` [Buildroot] [PATCH v5 6/9] package/netopeer2: bump version to 2.2.35 Heiko Thiery
2025-01-14  7:29 ` [Buildroot] [PATCH v5 7/9] support/testing/tests/package/test_sysrepo.py: add new test Heiko Thiery
2025-01-14  7:29 ` [Buildroot] [PATCH v5 8/9] support/testing/tests/package/test_netopeer2.py: " Heiko Thiery
2025-01-14  7:29 ` [Buildroot] [PATCH v5 9/9] package/netopeer2: build host variant only when doing sysrepo setup Heiko Thiery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250114072947.284965-4-heiko.thiery@gmail.com \
    --to=heiko.thiery@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=fiona.klute@gmx.de \
    --cc=jan.kundrat@cesnet.cz \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.