From: Jakub Kicinski <kuba@kernel.org>
To: Jiayuan Chen <mrpre@163.com>
Cc: bpf@vger.kernel.org, jakub@cloudflare.com,
john.fastabend@gmail.com, netdev@vger.kernel.org,
martin.lau@linux.dev, ast@kernel.org, edumazet@google.com,
davem@davemloft.net, dsahern@kernel.org, pabeni@redhat.com,
linux-kernel@vger.kernel.org, song@kernel.org, andrii@kernel.org,
mhal@rbox.co, yonghong.song@linux.dev, daniel@iogearbox.net,
xiyou.wangcong@gmail.com, horms@kernel.org, corbet@lwn.net,
eddyz87@gmail.com, cong.wang@bytedance.com, shuah@kernel.org,
mykolal@fb.com, jolsa@kernel.org, haoluo@google.com,
sdf@fomichev.me, kpsingh@kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH bpf v5 1/3] bpf: fix wrong copied_seq calculation
Date: Tue, 14 Jan 2025 10:01:08 -0800 [thread overview]
Message-ID: <20250114100108.121f9d5a@kernel.org> (raw)
In-Reply-To: <nch3maxdymvvdq647hijycfj2y242o67wgkch3vksfgrkabtt3@xuskfpo426xz>
On Tue, 14 Jan 2025 14:35:34 +0800 Jiayuan Chen wrote:
> > To state the obvious feels like the abstraction between TCP and psock
> > has broken down pretty severely at this stage. You're modifying TCP
> > and straight up calling TCP functions from skmsg.c :(
> >
> You are right!
>
> How about we construct code like this:
>
> sk_psock_strp_read_sock(strp) skmsg.c
> tcp_bpf_strp_read_sock(sk) tcp_bpf.c
> tcp_read_sock_noack(sk) tcp.c
>
> In skmsg.c we just register read_sock handler for strparser, then move
> core code into tcp_bpf.c. I believe it makes more sense than before as
> there already exist some psock with tcp operation(especially ops handler)
> implemented in tcp_bpf.c.
Yes, that's slightly better, thanks
next prev parent reply other threads:[~2025-01-14 18:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 9:43 [PATCH bpf v5 0/3] bpf: fix wrong copied_seq calculation and add tests Jiayuan Chen
2025-01-09 9:43 ` [PATCH bpf v5 1/3] bpf: fix wrong copied_seq calculation Jiayuan Chen
2025-01-14 0:04 ` Jakub Kicinski
2025-01-14 6:35 ` Jiayuan Chen
2025-01-14 18:01 ` Jakub Kicinski [this message]
2025-01-14 11:27 ` Jakub Sitnicki
2025-01-09 9:44 ` [PATCH bpf v5 2/3] selftests/bpf: add strparser test for bpf Jiayuan Chen
2025-01-09 9:44 ` [PATCH bpf v5 3/3] bpf, strparser, docs: Add new callback " Jiayuan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250114100108.121f9d5a@kernel.org \
--to=kuba@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cong.wang@bytedance.com \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=horms@kernel.org \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mhal@rbox.co \
--cc=mrpre@163.com \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=xiyou.wangcong@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.