All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: kan.liang@linux.intel.com
Cc: mingo@redhat.com, acme@kernel.org, namhyung@kernel.org,
	irogers@google.com, adrian.hunter@intel.com,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	ak@linux.intel.com, eranian@google.com,
	dapeng1.mi@linux.intel.com
Subject: Re: [PATCH V8 2/2] perf/x86/intel: Support PEBS counters snapshotting
Date: Tue, 14 Jan 2025 11:30:15 +0100	[thread overview]
Message-ID: <20250114103015.GN5388@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20250106142103.1735729-2-kan.liang@linux.intel.com>

On Mon, Jan 06, 2025 at 06:21:03AM -0800, kan.liang@linux.intel.com wrote:

> The current Linux perf sample read feature intends to read the counters
> of other member events when the leader event is overflowing.

This doesn't sound right. Any event in the group that has 'read_format &
FORMAT_GROUP' will read the entire group. There is absolutely nothing
leader specific here. Nor sampling for that matter, read() also works.

You can have 3 sampling events, all with FORMAT_GROUP on, with a
non-sampling leader.

Anyway, let me go read the code...



  reply	other threads:[~2025-01-14 10:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-06 14:21 [PATCH V8 1/2] perf: Avoid the read if the count is already updated kan.liang
2025-01-06 14:21 ` [PATCH V8 2/2] perf/x86/intel: Support PEBS counters snapshotting kan.liang
2025-01-14 10:30   ` Peter Zijlstra [this message]
2025-01-14 12:00   ` Peter Zijlstra
2025-01-14 17:52     ` Liang, Kan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250114103015.GN5388@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=eranian@google.com \
    --cc=irogers@google.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.