From: "Michał Pecio" <michal.pecio@gmail.com>
To: Niklas Neronin <niklas.neronin@linux.intel.com>
Cc: mathias.nyman@linux.intel.com, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 2/2] usb: xhci: set page size to the xHCI-supported size
Date: Tue, 14 Jan 2025 10:34:35 +0100 [thread overview]
Message-ID: <20250114103435.744bdc2f@foxbook> (raw)
In-Reply-To: <20250113143037.2131346-3-niklas.neronin@linux.intel.com>
On Mon, 13 Jan 2025 16:30:37 +0200, Niklas Neronin wrote:
> +static void xhci_hcd_page_size(struct xhci_hcd *xhci)
> +{
> + u32 page_shift;
> +
> + page_shift = readl(&xhci->op_regs->page_size) & XHCI_PAGE_SIZE_MASK;
If there is a v3 of this series coming for other reasons, I think it
would also make sense to rename this to simply 'page_size' or something
like that.
Shift suggests that it's the logarithm of page size, but it is not.
Regards,
Michal
prev parent reply other threads:[~2025-01-14 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 14:30 [PATCH v2 0/2] usb: xhci: page size improvements Niklas Neronin
2025-01-13 14:30 ` [PATCH v2 1/2] usb: xhci: correct debug message page size calculation Niklas Neronin
2025-01-13 16:00 ` Michał Pecio
2025-01-14 8:31 ` Neronin, Niklas
2025-01-13 14:30 ` [PATCH v2 2/2] usb: xhci: set page size to the xHCI-supported size Niklas Neronin
2025-01-14 9:34 ` Michał Pecio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250114103435.744bdc2f@foxbook \
--to=michal.pecio@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=niklas.neronin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.