From: Jakub Kicinski <kuba@kernel.org>
To: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
Cc: netdev@vger.kernel.org, andrew@lunn.ch,
Julian.FRIEDRICH@frequentis.com, f.fainelli@gmail.com,
olteanv@gmail.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, linux-kernel@vger.kernel.org,
upstream+netdev@sigma-star.at
Subject: Re: [PATCH v3] net: dsa: mv88e6xxx: propperly shutdown PPU re-enable timer on destroy
Date: Tue, 14 Jan 2025 15:27:29 -0800 [thread overview]
Message-ID: <20250114152729.4307e3a8@kernel.org> (raw)
In-Reply-To: <20250113084912.16245-1-david.oberhollenzer@sigma-star.at>
On Mon, 13 Jan 2025 09:49:12 +0100 David Oberhollenzer wrote:
> @@ -7323,6 +7323,8 @@ static int mv88e6xxx_probe(struct mdio_device *mdiodev)
> mv88e6xxx_g1_irq_free(chip);
> else
> mv88e6xxx_irq_poll_free(chip);
> +out_phy:
> + mv88e6xxx_phy_destroy(chip);
> out:
> if (pdata)
> dev_put(pdata->netdev);
If this is the right ordering the order in mv88e6xxx_remove()
looks suspicious. We call mv88e6xxx_phy_destroy() pretty early
and then unregister from DSA. Isn't there a window where DSA
callbacks can reschedule the timer?
--
pw-bot: cr
next prev parent reply other threads:[~2025-01-14 23:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 8:49 [PATCH v3] net: dsa: mv88e6xxx: propperly shutdown PPU re-enable timer on destroy David Oberhollenzer
2025-01-14 23:27 ` Jakub Kicinski [this message]
2025-04-01 8:12 ` David Oberhollenzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250114152729.4307e3a8@kernel.org \
--to=kuba@kernel.org \
--cc=Julian.FRIEDRICH@frequentis.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=david.oberhollenzer@sigma-star.at \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=upstream+netdev@sigma-star.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.