From: Stephen Hemminger <stephen@networkplumber.org>
To: "Ariel Otilibili-Anieli" <otilibil@eurecom.fr>
Cc: dev@dpdk.org, "Thomas Monjalon" <thomas@monjalon.net>,
"David Marchand" <david.marchand@redhat.com>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
"Ori Kam" <orika@nvidia.com>,
stable@dpdk.org
Subject: Re: [PATCH 2/2] drivers/net/sfc: remove unused value
Date: Tue, 14 Jan 2025 15:34:19 -0800 [thread overview]
Message-ID: <20250114153419.0a2753ab@hermes.local> (raw)
In-Reply-To: <786c4-6786c100-169-3a9adec0@216129648>
On Tue, 14 Jan 2025 20:54:51 +0100
"Ariel Otilibili-Anieli" <otilibil@eurecom.fr> wrote:
> Hello Stephen,
>
> On Tuesday, January 14, 2025 19:47 CET, Stephen Hemminger <stephen@networkplumber.org> wrote:
>
> > On Fri, 13 Dec 2024 22:41:55 +0100
> > Ariel Otilibili <otilibil@eurecom.fr> wrote:
> >
> > > Coverity issue: 384444
> > > Fixes: a62ec90522a ("net/sfc: add port representors infrastructure")
> > > Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> > > Cc: stable@dpdk.org
> > > Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
> > > ---
> >
> > This gets checkpatch warning when I merged the SHA value is not correct.
> >
> > ### [PATCH] net/sfc: remove unused value
> >
> > WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure")'
> >
>
> Thanks for the heads up; I'll set the correct length in my .gitconfig
> > Bad
> > Fixes: a62ec90522a ("net/sfc: add port representors infrastructure")
> > Good
> > Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure")
> Have a good one,
> Ariel
>
Also, please send a patch to add your address to the .mailmap file.
Right now, check-git-log.sh script is complaining.
next prev parent reply other threads:[~2025-01-14 23:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 21:41 [PATCH 0/2] clear out Coverity issues 384444 & 451221 Ariel Otilibili
2024-12-13 21:41 ` [PATCH 1/2] examples/flow_filtering: remove unused variable Ariel Otilibili
2024-12-13 21:41 ` [PATCH 2/2] drivers/net/sfc: remove unused value Ariel Otilibili
2025-01-14 18:47 ` Stephen Hemminger
2025-01-14 19:54 ` Ariel Otilibili-Anieli
2025-01-14 23:34 ` Stephen Hemminger [this message]
2025-01-15 10:51 ` Thomas Monjalon
2025-01-15 12:11 ` [PATCH v2 0/3] clear out Coverity issues 384444 & 451221 Ariel Otilibili
2025-01-15 12:11 ` [PATCH v2 1/3] examples/flow_filtering: remove unused variable Ariel Otilibili
2025-01-15 12:11 ` [PATCH v2 2/3] drivers/net/sfc: remove unused value Ariel Otilibili
2025-01-15 12:11 ` [PATCH v2 3/3] Update .mailmap Ariel Otilibili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250114153419.0a2753ab@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=orika@nvidia.com \
--cc=otilibil@eurecom.fr \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.