From: Jakub Kicinski <kuba@kernel.org>
To: John Daley <johndale@cisco.com>
Cc: shuah@kernel.org, sdf@fomichev.me, willemb@google.com,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/1] selftests: drv-net-hw: inject pp_alloc_fail errors in the right place
Date: Tue, 14 Jan 2025 16:37:08 -0800 [thread overview]
Message-ID: <20250114163708.63e4d244@kernel.org> (raw)
In-Reply-To: <20250114223159.29677-2-johndale@cisco.com>
On Tue, 14 Jan 2025 14:31:59 -0800 John Daley wrote:
> The tool pp_alloc_fail.py tested error recovery by injecting errors
> into the function page_pool_alloc_pages(). The page pool allocation
> function page_pool_dev_alloc() does not end up calling
> page_pool_alloc_pages(). page_pool_alloc_netmems() seems to be the
> function that is called by all of the page pool alloc functions in
> the API, so move error injection to that function instead.
LGTM, thanks!
Please resend and CC netdev@, tho.
next prev parent reply other threads:[~2025-01-15 0:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 22:31 [PATCH net-next 0/1] selftests: drv-net-hw: fix pp_alloc_fail test error John Daley
2025-01-14 22:31 ` [PATCH net-next 1/1] selftests: drv-net-hw: inject pp_alloc_fail errors in the right place John Daley
2025-01-15 0:37 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-01-15 18:13 [PATCH net-next 0/1] selftests: drv-net-hw: fix pp_alloc_fail test error John Daley
2025-01-15 18:13 ` [PATCH net-next 1/1] selftests: drv-net-hw: inject pp_alloc_fail errors in the right place John Daley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250114163708.63e4d244@kernel.org \
--to=kuba@kernel.org \
--cc=johndale@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.