From: Jakub Kicinski <kuba@kernel.org>
To: Li Li <dualli@chromium.org>
Cc: dualli@google.com, corbet@lwn.net, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, donald.hunter@gmail.com,
gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com,
maco@android.com, joel@joelfernandes.org, brauner@kernel.org,
cmllamas@google.com, surenb@google.com, arnd@arndb.de,
masahiroy@kernel.org, bagasdotme@gmail.com, horms@kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
netdev@vger.kernel.org, hridya@google.com, smoreland@google.com,
kernel-team@android.com
Subject: Re: [PATCH v13 1/3] tools: ynl-gen: add trampolines for sock-priv
Date: Wed, 15 Jan 2025 09:11:47 -0800 [thread overview]
Message-ID: <20250115091147.0d4c7497@kernel.org> (raw)
In-Reply-To: <CANBPYPiFY1YYXvo+uf3=0mmahFp3qTBbW=dxp11MsPf68j43Lg@mail.gmail.com>
On Wed, 15 Jan 2025 08:44:37 -0800 Li Li wrote:
> On Wed, Jan 15, 2025 at 8:13 AM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Wed, 15 Jan 2025 02:29:48 -0800 Li Li wrote:
> > > From: Li Li <dualli@google.com>
> > >
> > > This fixes the CFI failure at genl-sk_priv_get().
> > >
> > > Suggested-by: Jakub Kicinski <kuba@kernel.org>
> > > Signed-off-by: Li Li <dualli@google.com>
> >
> > No, no, this is a fix. We'll try to send it to Linus tomorrow.
>
> Thank you for prioritizing the fix!
>
> There's another trivial issue which I just realized after sending out the
> patchset. When "sock-priv" is a pointer (like the example below), ynl-gen
> generates ugly code and fails scripts/checkpatch.
>
> Should I use typedef instead although it seems discouraged according to
> https://www.kernel.org/doc/html/latest/process/coding-style.html?
>
> YAML:
> + sock-priv: struct binder_context *
We can adjust that later, but I think cleanest fix may be to wrap the
priv in a separate struct, even if it only has one member.
next prev parent reply other threads:[~2025-01-15 17:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 10:29 [PATCH v13 0/3] binder: report txn errors via generic netlink Li Li
2025-01-15 10:29 ` [PATCH v13 1/3] tools: ynl-gen: add trampolines for sock-priv Li Li
2025-01-15 16:13 ` Jakub Kicinski
2025-01-15 16:44 ` Li Li
2025-01-15 17:11 ` Jakub Kicinski [this message]
2025-01-15 10:29 ` [PATCH v13 2/3] netdev-genl: run ynl-regen to fix CFI failure Li Li
2025-01-15 10:29 ` [PATCH v13 3/3] binder: report txn errors via generic netlink Li Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250115091147.0d4c7497@kernel.org \
--to=kuba@kernel.org \
--cc=arnd@arndb.de \
--cc=arve@android.com \
--cc=bagasdotme@gmail.com \
--cc=brauner@kernel.org \
--cc=cmllamas@google.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dualli@chromium.org \
--cc=dualli@google.com \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms@kernel.org \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=masahiroy@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=smoreland@google.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.