From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC394C02180 for ; Wed, 15 Jan 2025 14:25:04 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4YY7Yq0RF9z2ysB; Thu, 16 Jan 2025 01:25:03 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2604:1380:45d1:ec00::3" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1736951102; cv=none; b=dyELhbxa0EQtljP0zl+2DmfrsjeK034hO2i6E/S3qU0hMB0+FTtoQChtzNbWkBikRT3cxUOhfZh3AJupOk87w2EfAh3IMRJARlZFVmWLZPJSOxWo/CzGzHaONPqEPSxRBLysz4w7WbQHpTNtUKcvcJHED8ct4X/gJRJOmE1pnUXwAShnKuwHqVTvW5tPjbLAVwc/QDuYGijZswYeatO3d74fiySUGok2dB9AqrHt2GpoYoo6ewAyyo0FWhWWXflvSgUT8qR5aRUDdamtDD+liFFXRTRm+Tij8DWmQF/jFjZRYAEDaoUqkzN8j/SJ+IG7wGEpNLz+HNmRtVAU8mtFmQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1736951102; c=relaxed/relaxed; bh=xaOcGj9j9Cemvm+vFePyCuGaT0+qHLpoq0/snIH1qN4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CEGKq15gSrhCCKvjHRA2j1pWfbvZoOND/xyniNBUtgE+7dhnxIfGHsmfvRPErgTGixhHian7K4CLYnewG7OLo/qxu87gP9kA8FGcenb4TA3ZDX3D1JcI1PFRIhKgZY4c/1Cl+X0JbTYDBS2KyXcPAWzU88wYt3Vdfo02kjjibMNhHFpNU1Jpce64NRUEkbgSfgv/LnwWuPTB4KhgYuzl+fs6dIiWay4u8x59K1gKopF475MB4xHhmrPrA64f+YiAkHXAnhcfnyuglIK4/uiLGEhuTvj2MPZOwOsE/kM+A5irwbVfUKkQxl+4fSQY0GKDKmobsZ1AJmOt0CUcJhsx0g== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=upw8EeuX; dkim-atps=neutral; spf=pass (client-ip=2604:1380:45d1:ec00::3; helo=nyc.source.kernel.org; envelope-from=robh@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=upw8EeuX; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:45d1:ec00::3; helo=nyc.source.kernel.org; envelope-from=robh@kernel.org; receiver=lists.ozlabs.org) Received: from nyc.source.kernel.org (nyc.source.kernel.org [IPv6:2604:1380:45d1:ec00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4YY7Yp2Yt5z2yZ6 for ; Thu, 16 Jan 2025 01:25:02 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id E6325A4056A; Wed, 15 Jan 2025 14:23:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D1BAC4CED1; Wed, 15 Jan 2025 14:24:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736951098; bh=WMcIZXIWDa7GXnAeCZ5NxIJiTsw13XWfpqK4pCdgiWc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=upw8EeuXYaML9/AhOywPJDa8xi5WeR9m2yIsNolj7dP6UH8uX/xTo9rVWXny5BMTZ 5kTFQyivcoBL+oastN9JqrQe83FruI51a77YqLwe3+7tX9GRcy/piFAAR5Hi/iZ3Ob D0a7xaDbn513HeQ/MUnlsaiuvxDctoKXJhl3txNtdwiRqfYrJEhk4eeo5P1X0Z6oFJ jP89kAQhk5CKJsTMXGDDzO5WYoXqqIhFWMm/6UbCeTkVhvs6DUJMf816Z5iEyHUkO+ bake0gHU9EG6GTTYaKYBI4BEEZ1A+HJzsGVWCiqY4AVHvCQ8HDDmEv0nHySoX000YD k1PSgi2nMvPiA== Date: Wed, 15 Jan 2025 08:24:57 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Ninad Palsule , minyard@acm.org, krzk+dt@kernel.org, conor+dt@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, openipmi-developer@lists.sourceforge.net, netdev@vger.kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, devicetree@vger.kernel.org, eajames@linux.ibm.com, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 03/10] dt-bindings: gpio: ast2400-gpio: Add hogs parsing Message-ID: <20250115142457.GA3859772-robh@kernel.org> References: <20250114220147.757075-1-ninad@linux.ibm.com> <20250114220147.757075-4-ninad@linux.ibm.com> X-Mailing-List: linux-aspeed@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jan 15, 2025 at 09:45:50AM +0100, Krzysztof Kozlowski wrote: > On Tue, Jan 14, 2025 at 04:01:37PM -0600, Ninad Palsule wrote: > > Allow parsing GPIO controller children nodes with GPIO hogs. > > > > Signed-off-by: Ninad Palsule > > --- > > .../devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml > > index b9afd07a9d24..b9bc4fe4d5a6 100644 > > --- a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml > > +++ b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml > > @@ -46,6 +46,12 @@ properties: > > minimum: 12 > > maximum: 232 > > > > +patternProperties: > > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": > > Choose one - suffix or prefix. More popular is suffix. I was about to say that, but this matches what gpio-hog.yaml defines. Why we did both, I don't remember. We could probably eliminate 'hog-[0-9]+' as that doesn't appear to be used much. Long term, I want to make all gpio controllers reference a gpio controller schema and put the hog stuff there. Then we have the node names defined in 1 place. Rob